[HDDS-8024] When readChunk from a datanode fails, retry other datanodes.

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4.0
• Fix Version/s: 1.4.0
• Component/s: Ozone Client
• Labels: pull-request-available
• Target Version/s: 1.4.0
• Assignee: Tsz-wo Sze
• Reporter: Attila Doroszlai
• Created: 24/Feb/23 07:47
• Updated: 21/Jul/23 19:21
• Resolved: 04/Mar/23 01:04

Description

https://github.com/adoroszlai/ozone-build-results/blob/master/2023/02/03/19930/it-filesystem/hadoop-ozone/integration-test/org.apache.hadoop.fs.ozone.contract.ITestOzoneContractCreate.txt

ITestOzoneContractCreate.testSyncable  Time elapsed: 0.309 s  <<< ERROR!
java.io.IOException: Inconsistent read for blockID=conID: 1 locID: 111677748019200007 bcsId: 0 length=2 position=1 numBytesToRead=1 numBytesRead=-1
	at org.apache.hadoop.ozone.client.io.KeyInputStream.checkPartBytesRead(KeyInputStream.java:175)
	at org.apache.hadoop.hdds.scm.storage.MultipartInputStream.readWithStrategy(MultipartInputStream.java:97)
	at org.apache.hadoop.hdds.scm.storage.ExtendedInputStream.read(ExtendedInputStream.java:54)
	at org.apache.hadoop.hdds.scm.storage.ExtendedInputStream.read(ExtendedInputStream.java:41)
	at org.apache.hadoop.fs.ozone.OzoneFSInputStream.read(OzoneFSInputStream.java:55)
	at java.io.FilterInputStream.read(FilterInputStream.java:83)
	at org.apache.hadoop.fs.contract.AbstractContractCreateTest.validateSyncableSemantics(AbstractContractCreateTest.java:548)
	at org.apache.hadoop.fs.contract.AbstractContractCreateTest.testSyncable(AbstractContractCreateTest.java:459)

https://github.com/adoroszlai/hadoop-ozone/actions/runs/4257319915/jobs/7407314181#step:5:3310

java.io.IOException: Inconsistent read for blockID=conID: 1 locID: 111677748019200001 bcsId: 0 length=1120 position=97 numBytesToRead=1023 numBytesRead=-1
	at org.apache.hadoop.ozone.client.io.KeyInputStream.checkPartBytesRead(KeyInputStream.java:175)
	at org.apache.hadoop.hdds.scm.storage.MultipartInputStream.readWithStrategy(MultipartInputStream.java:97)
	at org.apache.hadoop.hdds.scm.storage.ExtendedInputStream.read(ExtendedInputStream.java:54)
	at org.apache.hadoop.fs.ozone.OzoneFSInputStream.read(OzoneFSInputStream.java:64)
	at java.io.DataInputStream.read(DataInputStream.java:149)
	at org.apache.hadoop.fs.ozone.TestHSync.runTestHSync(TestHSync.java:188)
	at org.apache.hadoop.fs.ozone.TestHSync.runTestHSync(TestHSync.java:143)
	at org.apache.hadoop.fs.ozone.TestHSync.testO3fsHSync(TestHSync.java:116)

I guess these two different tests both exercise HSync.

CC weichiu, szetszwo

---

The datanode may fail to serve readChunk but the client won't retry other datanodes. We will change it to retry other datanodes in the JIRA.

Issue Links

• Discovered while testing: HDDS-7593 Supporting HSync and lease recovery
• is duplicated by: HDDS-8033 Intermittent error in TestHSync.testO3fsHSync
• is related to: HDDS-8146 TestHSync is no longer flaky
• is related to: HDDS-8090 When getBlock from a datanode fails, retry other datanodes.
• relates to: HDDS-8942 Intermittent failure in ITestOzoneContractCreate#testSyncable
• links to: GitHub Pull Request #4336