[HDDS-7914] [Snapshot] Block FS API access to deleted (non-active) snapshots

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.4.0
• Component/s: Ozone Manager
• Labels: ozone-snapshot pull-request-available
• Assignee: Siyao Meng
• Reporter: Jyotirmoy Sinha
• Created: 07/Feb/23 10:02
• Updated: 29/Mar/23 22:27
• Resolved: 29/Mar/23 22:26

Description

Keys pertaining to deleted snapshot are still accessible through fs -ls.

bash-4.2$ ozone sh snapshot delete vol1/buck1 snap4
bash-4.2$ ozone sh snapshot ls vol1/buck1
[ {
  "volumeName" : "vol1",
  "bucketName" : "buck1",
  "name" : "snap1",
  "creationTime" : 1675762737085,
  "snapshotStatus" : "SNAPSHOT_DELETED",
  "snapshotID" : "47c9566f-f936-4ae0-a8ea-2eebf90ef8a3",
  "snapshotPath" : "vol1/buck1",
  "checkpointDir" : "-47c9566f-f936-4ae0-a8ea-2eebf90ef8a3"
}, {
  "volumeName" : "vol1",
  "bucketName" : "buck1",
  "name" : "snap2",
  "creationTime" : 1675762805211,
  "snapshotStatus" : "SNAPSHOT_ACTIVE",
  "snapshotID" : "3ef730ef-90a7-4ce3-a76f-f766fcd64e1e",
  "snapshotPath" : "vol1/buck1",
  "checkpointDir" : "-3ef730ef-90a7-4ce3-a76f-f766fcd64e1e"
}, {
  "volumeName" : "vol1",
  "bucketName" : "buck1",
  "name" : "snap3",
  "creationTime" : 1675763112780,
  "snapshotStatus" : "SNAPSHOT_ACTIVE",
  "snapshotID" : "e3f0ef8b-5396-4b1d-afe7-1a64279967e5",
  "snapshotPath" : "vol1/buck1",
  "checkpointDir" : "-e3f0ef8b-5396-4b1d-afe7-1a64279967e5"
}, {
  "volumeName" : "vol1",
  "bucketName" : "buck1",
  "name" : "snap4",
  "creationTime" : 1675763223154,
  "snapshotStatus" : "SNAPSHOT_DELETED",
  "snapshotID" : "9d3b12e0-a2a2-4bc2-b733-8b7d6e14aef3",
  "snapshotPath" : "vol1/buck1",
  "checkpointDir" : "-9d3b12e0-a2a2-4bc2-b733-8b7d6e14aef3"
} ]
bash-4.2$ ozone sh snapshot delete vol1/buck1 snap4
FILE_NOT_FOUND Snapshot is already deleted. Pending reclamation.
bash-4.2$
bash-4.2$ ozone fs -ls /vol1/buck1/.snapshot/snap4
Found 1 items
-rw-rw-rw-   3 hadoop hadoop       3879 2023-02-07 09:46 /vol1/buck1/.snapshot/snap4/key1

Issue Links

• blocks: HDDS-8201 [Snapshot] Improve TestOmSnapshotFileSystem
• is depended upon by: HDDS-7935 [Snapshot] LRU Cache entries may get evicted/closed during long running processes
• is related to: HDDS-6855 Path Based Access for Ozone Snapshots
• links to: GitHub Pull Request #4419