[HDDS-7063] CreateContainer metrics are never updated

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3.0
• Fix Version/s: 1.3.0
• Component/s: Ozone Datanode
• Labels: pull-request-available
• Assignee: Dave Teng
• Reporter: Wei-Chiu Chuang
• Created: 28/Jul/22 20:18
• Updated: 04/Aug/22 22:34
• Resolved: 04/Aug/22 22:33

Description

The CreateContainer metric in StorageContainerMetrics on DN is always zero.

{
"name": "Hadoop:service=HddsDatanode,name=StorageContainerMetrics",
"modelerType": "StorageContainerMetrics",
"tag.Context": "dfs",
"tag.Hostname": "example-1.example.com",
"numCreateContainer": 0,
"bytesCreateContainer": 0,
"LatencyCreateContainerNumOps": 0,
"LatencyCreateContainerAvgTime": 0,

It's because client never issues an explicit request to a create container.
Create Container should happen only as part of Write_Data phase of writeChunk.

I believe we should increment the CreateContainer metrics here in its handler: https://github.com/apache/ozone/blob/7e5cdde59ff584e142af0b664d7ad948159b7b91/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java#L243

Issue Links

• links to: GitHub Pull Request #3643