[HDDS-7032] RDBStore#getUpdatesSince should throw SequenceNumberNotFoundException back to the caller in order for Recon to fall back to full snapshot

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.3.0
• Labels: pull-request-available
• Assignee: Siyao Meng
• Reporter: Siyao Meng
• Created: 21/Jul/22 16:01
• Updated: 02/Nov/22 10:50
• Resolved: 22/Jul/22 14:17

Description

Recon expects an exception to be thrown in order to fall back to full snapshot when an OM DB delta update cannot be retrieved:

https://github.com/apache/ozone/blob/5ed0e0a9b4c8355f4cde064cc605bc419dacd9c3/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/spi/impl/OzoneManagerServiceProviderImpl.java#L456-L478

However, the current logic implies that RDBStore#getUpdatesSince will not ever throw SequenceNumberNotFoundException back to the client (Recon) because it is caught in try-catch. A patch earlier broke this intended behavior.

Solution:
Restore the intended behavior by explicitly catching SequenceNumberNotFoundException and throwing it back to the client.

Issue Links

• is broken by: HDDS-6323 Close RocksObject(s)
• relates to: HDDS-7451 Add UT of SyncDataFromOM for SequenceNumberNotFoundException
• links to: GitHub Pull Request #3613