[HDDS-6955] Fix NPE in createStreamKey when replicationConfig is not set

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Labels: pull-request-available
• Assignee: Kaijie Chen
• Reporter: Kaijie Chen
• Created: 27/Jun/22 12:01
• Updated: 12/Jul/22 10:58
• Resolved: 12/Jul/22 10:49

Description

createStreamKey() will throws NPE when replication config is not specified.

$ ./ozone sh key put /vol1/bucket1/key1 ~/ft_local/ozone-1.3.0-SNAPSHOT.tar.gz 
java.lang.NullPointerException
        at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:889)        at org.apache.hadoop.hdds.scm.client.HddsClientUtils.checkNotNull(HddsClientUtils.java:223)
        at org.apache.hadoop.ozone.client.rpc.RpcClient.createStreamKey(RpcClient.java:1199)        at org.apache.hadoop.ozone.client.OzoneBucket.createStreamKey(OzoneBucket.java:617)        at org.apache.hadoop.ozone.shell.keys.PutKeyHandler.execute(PutKeyHandler.java:120)
        at org.apache.hadoop.ozone.shell.Handler.call(Handler.java:98)
        at org.apache.hadoop.ozone.shell.Handler.call(Handler.java:44)
        at picocli.CommandLine.executeUserObject(CommandLine.java:1953)
        at picocli.CommandLine.access$1300(CommandLine.java:145)
        at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2352)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2346)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2311)
        at picocli.CommandLine$AbstractParseResultHandler.handleParseResult(CommandLine.java:2172)
        at picocli.CommandLine.parseWithHandlers(CommandLine.java:2550)
        at picocli.CommandLine.parseWithHandler(CommandLine.java:2485)
        at org.apache.hadoop.hdds.cli.GenericCli.execute(GenericCli.java:96)        at org.apache.hadoop.ozone.shell.OzoneShell.lambda$execute$0(OzoneShell.java:55)
        at org.apache.hadoop.hdds.tracing.TracingUtil.executeInNewSpan(TracingUtil.java:159)
        at org.apache.hadoop.ozone.shell.OzoneShell.execute(OzoneShell.java:53)
        at org.apache.hadoop.hdds.cli.GenericCli.run(GenericCli.java:87)
        at org.apache.hadoop.ozone.shell.OzoneShell.main(OzoneShell.java:47)

 

It works fine if replication config is specified.

$ ./ozone sh key put /vol1/bucket1/key1 ~/ft_local/ozone-1.3.0-SNAPSHOT.tar.gz --replication THREE --type RATIS

Issue Links

• links to: GitHub Pull Request #3559