[HDDS-6502] Blocks of old key versions are not deleted on key deletion

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.3.0
• Labels: pull-request-available
• Assignee: Hanisha Koneru
• Reporter: Hanisha Koneru
• Created: 23/Mar/22 23:14
• Updated: 04/Apr/22 22:40
• Resolved: 29/Mar/22 17:05

Description

When a key is deleted from OM, only the latest version of blocks are sent to SCM for deletion. 
In OmMetadataManagerImpl#getPendingDeletionKeys(), we gey the latest version location information and return only those blocks for deletion to KeyDeletingService. This leads to older versions of blocks being orphaned.

RepeatedOmKeyInfo infoList = kv.getValue();
// Get block keys as a list.
for (OmKeyInfo info : infoList.getOmKeyInfoList()) {
  OmKeyLocationInfoGroup latest = info.getLatestVersionLocations();
  List<BlockID> item = latest.getLocationList().stream()
    .map(b -> new BlockID(b.getContainerID(), b.getLocalID()))
    .collect(Collectors.toList());
  BlockGroup keyBlocks = BlockGroup.newBuilder()
    .setKeyName(kv.getKey())
    .addAllBlockIDs(item)
    .build();
  keyBlocksList.add(keyBlocks);
  currentCount++;
}

Issue Links

• is related to: HDDS-6316 Potential orphan blocks when keys are overwritten
• links to: GitHub Pull Request #3232