[HDDS-6291] Do not let slf4j-log4j12 leak into Ozone FS shaded jar

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.3.0
• Fix Version/s: 1.3.0
• Component/s: build, Ozone Client
• Labels: pull-request-available
• Target Version/s: 1.3.0
• Assignee: Attila Doroszlai
• Reporter: Attila Doroszlai
• Created: 09/Feb/22 15:53
• Updated: 10/Feb/22 08:48
• Resolved: 10/Feb/22 08:47

Description

The following commit accidentally changed Ozone Client's dependency on slf4j-log4j12 from test to compile scope.

commit 9644f83c0ab86946e4f0f30ab6dadb222f000ebc
Author:     Wei-Chiu Chuang <[e-mail]>
AuthorDate: Mon Jan 10 09:02:57 2022 +0800
Commit:     GitHub <[e-mail]>
CommitDate: Mon Jan 10 09:02:57 2022 +0800

    HDDS-6086. Compute MD5MD5CRC file checksum using chunk checksums from DataNodes (#2919)

diff --git hadoop-ozone/client/pom.xml hadoop-ozone/client/pom.xml
index f7cbd5597..b5ba8e7e5 100644
--- hadoop-ozone/client/pom.xml
+++ hadoop-ozone/client/pom.xml
@@ -51,6 +51,10 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd">
     <dependency>
       <groupId>org.slf4j</groupId>
       <artifactId>slf4j-log4j12</artifactId>
+    </dependency>
+    <dependency>
+      <groupId>org.mockito</groupId>
+      <artifactId>mockito-core</artifactId>
       <scope>test</scope>
     </dependency>
   </dependencies>

Since this is a new dependency, it is silently added into the Ozone FS shaded jars:

[INFO] --- maven-shade-plugin:3.2.4:shade (default) @ ozone-filesystem-shaded ---
...
[INFO] Including org.slf4j:slf4j-log4j12:jar:1.7.30 in the shaded jar.

Issue Links

• is caused by: HDDS-6086 Compute MD5MD5CRC file checksum using chunk checksums from DataNodes
• links to: GitHub Pull Request #3064