[HDDS-6186] Selective checks: skip integration check for unit test changes

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Implemented
• Fix Version/s: 1.3.0
• Component/s: build, test
• Labels: pull-request-available
• Target Version/s: 1.3.0
• Assignee: Attila Doroszlai
• Reporter: Attila Doroszlai
• Created: 16/Jan/22 09:23
• Updated: 15/Feb/22 18:44
• Resolved: 15/Feb/22 06:21

Description

unit and integration checks run tests in mutually exclusive submodules. We may skip integration check if only unit tests are changed. However, we need to run integration if any helper is changed, since we don't know if it's used by integration tests or not.

We can distinguish tests and test utilities by:

1. file name pattern (Test*.java are tests, others are utilities) OR
2. extracting unit tests into separate submodule (similar to ratis-test in Ratis)

The first approach is quick and dirty.

The second one needs a bit more work, but is clean and has the additional benefit that all tests can be run despite any failures in dependencies. (Currently a test failure in e.g. hdds-common causes build/test in hdds-server-framework and other modules that depend on it.) The downside is that it may cause many merge conflicts for everyone (feature branches, other in-progress work, open PRs).

I propose to do it now the first way, then do it properly after current feature branches are merged.

Issue Links

• links to: GitHub Pull Request #3061