[HDDS-5503] On finalize upgrade actions not running

• Type: Sub-task
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 1.2.0
• Component/s: Ozone Datanode
• Labels: pull-request-available
• Target Version/s: 1.2.0
• Assignee: Mark Gui
• Reporter: Ethan Rose
• Created: 27/Jul/21 22:05
• Updated: 09/Aug/21 16:35
• Resolved: 09/Aug/21 16:35

Description

When running TestHDDSUpgrade integration tests, we can see the following log messages indicating the upgrade actions were registered:

INFO  upgrade.HDDSLayoutVersionManager (HDDSLayoutVersionManager.java:lambda$registerUpgradeActions$0(76)) - Registering Upgrade Action : ScmHAFirstUpgradeLayoutChangeAction
INFO  upgrade.HDDSLayoutVersionManager (HDDSLayoutVersionManager.java:lambda$registerUpgradeActions$0(76)) - Registering Upgrade Action : ScmHAUnfinalizedStateValidationAction
INFO  upgrade.HDDSLayoutVersionManager (HDDSLayoutVersionManager.java:lambda$registerUpgradeActions$0(76)) - Registering Upgrade Action : ScmOnFinalizeActionForDatanodeSchemaV2
INFO  upgrade.HDDSLayoutVersionManager (HDDSLayoutVersionManager.java:lambda$registerUpgradeActions$0(76)) - Registering Upgrade Action : DatanodeSchemaV2FinalizeAction

(Side note, we may want to come up with a naming convention for these so it's easier to tell what is what)

The logs do not show the messages for the on finalize actions for schema V2 on either the datanode or SCM, indicating they are not actually being run. Currently both these operations are no-ops so no breaking behavior was noticed. We do not yet have any on finalize actions that do real work.

The testing for upgrade actions registering and running uses a fair amount of mocking, which may miss cases that come up for the actual upgrade actions. We should verify that all upgrade actions get registered and run correctly as part of this Jira, and maybe implement more robust testing.

Issue Links

• blocks: HDDS-5432 Enable downgrade testing after 1.1.0 release
• links to: GitHub Pull Request #2476