[HDDS-5398] Avoid object creation in ReplicationManger debug log statements

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.0
• Fix Version/s: 1.2.0
• Component/s: SCM
• Labels: pull-request-available
• Target Version/s: 1.2.0
• Assignee: Stephen O'Donnell
• Reporter: Stephen O'Donnell
• Created: 29/Jun/21 16:02
• Updated: 30/Jun/21 08:18
• Resolved: 30/Jun/21 08:18

Description

There are a few debug log entries in replication manager like this:

    LOG.debug("Handling under-replicated container: {}",
        container.getContainerID());

      LOG.debug("Deleting empty container {} replicas,", container.containerID());

Especially the latter one, will always allocate a new ContainerID object on each call, even if debug is not enabled.

If we just pass "container" then it will use the container.toString() method inside the logger, only if debug is enabled. The ContainerInfo toString looks like:

  @Override
  public String toString() {
    return "ContainerInfo{"
        + "id=" + containerID
        + ", state=" + state
        + ", pipelineID=" + pipelineID
        + ", stateEnterTime=" + stateEnterTime
        + ", owner=" + owner
        + '}';
  }

It contains some extra information, but some of that may be useful if debugging a problem.

Issue Links

• links to: GitHub Pull Request #2379