[HDDS-5383] Eliminate expensive string creation in debug log messages

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 1.2.0
• Labels: pull-request-available
• Assignee: Keyi Song
• Reporter: Wei-Chiu Chuang
• Created: 24/Jun/21 13:22
• Updated: 28/Jun/21 09:22
• Resolved: 28/Jun/21 09:22

Description

Use IntelliJ and search with regex pattern: LOG\.debug.*toString

I found a number of bad log message practice where string objects are created or concatenated regardless log level.

Parameters passed to slf4j debug log are supposed to be O(1).

For example,

KeyManagerImpl.refreshPipeline

} catch (IOException ioEx) {
  LOG.debug("Get containerPipeline failed for {}",
      containerIDs.toString(), ioEx);

Issue Links

• links to: GitHub Pull Request #2372