[HDDS-5262] Improve CLI volume/bucket/key removeacl response

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.2.0
• Component/s: Ozone CLI
• Assignee: Siyao Meng
• Reporter: Siyao Meng
• Created: 21/May/21 18:17
• Updated: 21/May/21 18:17

Description

Before this patch, volume removeacl (almost) always returns success message, regardless of whether an actual ACL entry is removed or not:

bash-4.2$ ozone sh volume getacl vol2
[ {
  "type" : "USER",
  "name" : "testuser/[e-mail]",
  "aclScope" : "ACCESS",
  "aclList" : [ "ALL" ]
}, {
  "type" : "GROUP",
  "name" : "root",
  "aclScope" : "ACCESS",
  "aclList" : [ "ALL" ]
} ]
bash-4.2$ ozone sh volume removeacl -a=user:somenonexistentuser:a vol2
ACL user:somenonexistentuser:a[ACCESS] removed successfully.
bash-4.2$ ozone sh volume getacl vol2
[ {
  "type" : "USER",
  "name" : "testuser/[e-mail]",
  "aclScope" : "ACCESS",
  "aclList" : [ "ALL" ]
}, {
  "type" : "GROUP",
  "name" : "root",
  "aclScope" : "ACCESS",
  "aclList" : [ "ALL" ]
} ]

This isn't particularly useful since owners/admins still have to use getacl to check if an ACL is indeed removed via CLI. It makes more sense to just print out the ACL status after the operation.