Uploaded image for project: 'Apache Ozone'
  1. Apache Ozone
  2. HDDS-4444

Remove KeyManagerImpl#refreshPipeline because it is the same as refresh()

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 1.1.0
    • OM

    Description

      /**
       * Refresh pipeline info in OM by asking SCM.
       * @param value OmKeyInfo
       */
      @VisibleForTesting
      protected void refreshPipeline(OmKeyInfo value) throws IOException {
        Preconditions.checkNotNull(value, "OMKeyInfo cannot be null");
        refreshPipeline(Arrays.asList(value));
      } 
      /**
         * Refresh the key block location information by get latest info from SCM.
         * @param key
         */
        public void refresh(OmKeyInfo key) throws IOException {
          Preconditions.checkNotNull(key, "Key info can not be null");
          refreshPipeline(Arrays.asList(key));
        }
      

      Both methods are essentially the same. I suggeset remove refreshPipeline() since it's protected.

      Attachments

        Issue Links

          Activity

            People

              flirmnave Huang-Mu Zheng
              weichiu Wei-Chiu Chuang
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: