[HDDS-4418] TestContainerMetrics is flaky

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.1.0
• Component/s: test
• Labels: pull-request-available
• Target Version/s: 1.1.0
• Assignee: Marton Elek
• Reporter: Marton Elek
• Created: 02/Nov/20 15:37
• Updated: 03/Nov/20 14:04
• Resolved: 03/Nov/20 06:33

Description

TestContainerMetrics is flaky since HDDS-4359. Failed in following master builds:

2020/10/26/3569/it-ozone/hadoop-ozone/integration-test/TEST-org.apache.hadoop.ozone.container.metrics.TestContainerMetrics.xml
2020/10/27/3581/it-ozone/hadoop-ozone/integration-test/TEST-org.apache.hadoop.ozone.container.metrics.TestContainerMetrics.xml
2020/10/28/3591/it-ozone/hadoop-ozone/integration-test/TEST-org.apache.hadoop.ozone.container.metrics.TestContainerMetrics.xml
2020/10/29/3619/it-ozone/hadoop-ozone/integration-test/TEST-org.apache.hadoop.ozone.container.metrics.TestContainerMetrics.xml
2020/10/30/3628/it-ozone/hadoop-ozone/integration-test/TEST-org.apache.hadoop.ozone.container.metrics.TestContainerMetrics.xml
2020/10/30/3642/it-ozone/hadoop-ozone/integration-test/TEST-org.apache.hadoop.ozone.container.metrics.TestContainerMetrics.xml
2020/10/31/3650/it-ozone/hadoop-ozone/integration-test/TEST-org.apache.hadoop.ozone.container.metrics.TestContainerMetrics.xml
2020/10/31/3654/it-ozone/hadoop-ozone/integration-test/TEST-org.apache.hadoop.ozone.container.metrics.TestContainerMetrics.xml

Some of the added assertions couldn't be guaranteed all the time:

      // ReadTime and WriteTime vary from run to run, only checking non-zero
      Assert.assertNotEquals(0L, getLongCounter("ReadTime", volumeIOMetrics));
      Assert.assertNotEquals(0L, getLongCounter("WriteTime", volumeIOMetrics));

In very lucky case the read/write time can be zero.

Issue Links

• links to: GitHub Pull Request #1543