[HDDS-3999] OM NPE and shutdown while S3MultipartUploadCommitPartResponse#checkAndUpdateDB

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 1.0.0
• Fix Version/s: 1.0.0
• Component/s: Ozone Manager
• Labels: pull-request-available
• Assignee: Baolong Mao
• Reporter: Baolong Mao
• Created: 22/Jul/20 06:01
• Updated: 24/Jul/20 15:57
• Resolved: 24/Jul/20 15:57

Description

The related bad code.

The following is the part log of OM. If you want to see the full log, you can download the attachment.

2020-07-20 16:28:56,395 ERROR ratis.OzoneManagerDoubleBuffer (ExitUtils.java:terminate(133)) - Terminating with exit status 2: OMDoubleBuffer flush threadOMDoubleBufferFlushThreadencountered Throwable error
java.lang.NullPointerException
at org.apache.hadoop.ozone.om.response.s3.multipart.S3MultipartUploadCommitPartResponse.checkAndUpdateDB(S3MultipartUploadCommitPartResponse.java:99)
at org.apache.hadoop.ozone.om.ratis.OzoneManagerDoubleBuffer.lambda$null$0(OzoneManagerDoubleBuffer.java:256)
at org.apache.hadoop.ozone.om.ratis.OzoneManagerDoubleBuffer.addToBatchWithTrace(OzoneManagerDoubleBuffer.java:201)
at org.apache.hadoop.ozone.om.ratis.OzoneManagerDoubleBuffer.lambda$flushTransactions$1(OzoneManagerDoubleBuffer.java:254)
at java.util.Iterator.forEachRemaining(Iterator.java:116)
at org.apache.hadoop.ozone.om.ratis.OzoneManagerDoubleBuffer.flushTransactions(OzoneManagerDoubleBuffer.java:250)
at java.lang.Thread.run(Thread.java:748)
2020-07-20 16:28:56,426 INFO om.OzoneManagerStarter (StringUtils.java:lambda$startupShutdownMessage$0(124)) - SHUTDOWN_MSG:
/************************************************************
SHUTDOWN_MSG: Shutting down OzoneManager at BAOLOONGMAO-MB0/10.78.32.49
************************************************************/

Issue Links

• is caused by: HDDS-3685 Remove replay logic from actual request logic
• links to: GitHub Pull Request #1244