[HDDS-3974] StateContext#addPipelineActionIfAbsent does not work as expected

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.0.0
• Fix Version/s: 1.1.0
• Component/s: Ozone Datanode
• Labels: pull-request-available
• Assignee: Siyao Meng
• Reporter: Glen Geng
• Created: 16/Jul/20 11:18
• Updated: 10/Feb/21 17:31
• Resolved: 10/Feb/21 17:31

Description

/**
 * Add PipelineAction to PipelineAction queue if it's not present.
 *
 * @param pipelineAction PipelineAction to be added
 */
public void addPipelineActionIfAbsent(PipelineAction pipelineAction) {
  synchronized (pipelineActions) {
    /**
     * If pipelineAction queue already contains entry for the pipeline id
     * with same action, we should just return.
     * Note: We should not use pipelineActions.contains(pipelineAction) here
     * as, pipelineAction has a msg string. So even if two msgs differ though
     * action remains same on the given pipeline, it will end up adding it
     * multiple times here.
     */
    for (InetSocketAddress endpoint : endpoints) {
      Queue<PipelineAction> actionsForEndpoint =
          this.pipelineActions.get(endpoint);
      for (PipelineAction pipelineActionIter : actionsForEndpoint) {
        if (pipelineActionIter.getAction() == pipelineAction.getAction()
            && pipelineActionIter.hasClosePipeline() && pipelineAction
            .hasClosePipeline()
            && pipelineActionIter.getClosePipeline().getPipelineID()
            .equals(pipelineAction.getClosePipeline().getPipelineID())) {
          break;
        }
      }
      actionsForEndpoint.add(pipelineAction);
    }
  }
}

no matter absent or not, pipeline action will be added.

Issue Links

• links to: GitHub Pull Request #1898