[HDDS-3824] OM read requests should make SCM#refreshPipeline outside the BUCKET_LOCK

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0.0
• Component/s: Ozone Manager
• Labels: om-perf perfomance pull-request-available
• Assignee: Rakesh Radhakrishnan
• Reporter: Rakesh Radhakrishnan
• Created: 18/Jun/20 09:47
• Updated: 22/Jul/20 12:12
• Resolved: 16/Jul/20 20:55

Description

Refresh pipeline info does a call to SCM and it can be moved outside the BUCKET_LOCK, this would help to improve the performance of read/write mix workloads.

KeyManagerImpl.java

    metadataManager.getLock().acquireReadLock(BUCKET_LOCK, volumeName,
        bucketName);
    try {
.....
.....
        // No need to check if a key is deleted or not here, this is handled
        // when adding entries to cacheKeyMap from DB.
        if (args.getRefreshPipeline()) {
          refreshPipeline(entry.getValue().getKeyInfo());
        }
.....
.....
    } finally {
      metadataManager.getLock().releaseReadLock(BUCKET_LOCK, volumeName,
          bucketName);
    }

 

Code Reference:  KeyManagerImpl.java#L2071

Issue Links

• links to: GitHub Pull Request #1164