[HDDS-2510] Use isEmpty() to check whether the collection is empty or not in Ozone Manager module

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.5.0
• Component/s: Ozone Manager
• Labels: pull-request-available sonar
• Assignee: Aravindan Vijayan
• Reporter: Aravindan Vijayan
• Created: 15/Nov/19 17:01
• Updated: 24/Feb/20 20:55
• Resolved: 22/Nov/19 21:36

Description

Ozone Manager has a number of instances where the following sonar rule is flagged.

Using Collection.size() to test for emptiness works, but using Collection.isEmpty() makes the code more readable and can be more performant. The time complexity of any isEmpty() method implementation should be O(1) whereas some implementations of size() can be O.

An example of a flagged instance - https://sonarcloud.io/issues?myIssues=true&open=AW5md-W4KcVY8lQ4Zrv_&resolved=false

Issue Links

• links to: GitHub Pull Request #258