[HDDS-2483] Avoid fall-through in HddsUtils#getBlockID

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.5.0
• Labels: pull-request-available sonar
• Target Version/s: 0.5.0
• Assignee: Craig Condit
• Reporter: Attila Doroszlai
• Created: 14/Nov/19 16:06
• Updated: 24/Feb/20 20:55
• Resolved: 15/Nov/19 19:03

Description

switch in HddsUtils#getBlockID has potential fall-through. It should be handled explicitly (eg. throw exception or return null).

• https://sonarcloud.io/project/issues?id=hadoop-ozone&issues=AW5md-4qKcVY8lQ4ZsPe&open=AW5md-4qKcVY8lQ4ZsPe
• https://sonarcloud.io/project/issues?id=hadoop-ozone&issues=AW5md-4qKcVY8lQ4ZsPf&open=AW5md-4qKcVY8lQ4ZsPf
• https://sonarcloud.io/project/issues?id=hadoop-ozone&issues=AW5md-4qKcVY8lQ4ZsPg&open=AW5md-4qKcVY8lQ4ZsPg
• https://sonarcloud.io/project/issues?id=hadoop-ozone&issues=AW5md-4qKcVY8lQ4ZsPh&open=AW5md-4qKcVY8lQ4ZsPh
• https://sonarcloud.io/project/issues?id=hadoop-ozone&issues=AW5md-4qKcVY8lQ4ZsPi&open=AW5md-4qKcVY8lQ4ZsPi
• https://sonarcloud.io/project/issues?id=hadoop-ozone&issues=AW5md-4qKcVY8lQ4ZsPj&open=AW5md-4qKcVY8lQ4ZsPj

Issue Links

• links to: GitHub Pull Request #184