[HDDS-2445] Replace ToStringBuilder in BlockData

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.5.0
• Labels: performance pull-request-available
• Target Version/s: 0.5.0
• Assignee: Attila Doroszlai
• Reporter: Attila Doroszlai
• Created: 08/Nov/19 10:49
• Updated: 24/Feb/20 20:55
• Resolved: 13/Nov/19 14:01

Description

BlockData#toString uses ToStringBuilder for ease of implementation. This has a few problems:

1. ToStringBuilder uses StringBuffer, which is synchronized
2. the default buffer is 512 bytes, more than needed here
3. BlockID and ContainerBlockID both use another StringBuilder or StringBuffer for their toString implementation, leading to several allocations and copies

The flame graph shows that BlockData#toString may be responsible for 1.5% of total allocations while putting keys.

Issue Links

• links to: GitHub Pull Request #132