[HDDS-2270] Avoid buffer copying in ContainerStateMachine.loadSnapshot/persistContainerSet

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.5.0
• Component/s: Ozone Datanode
• Labels: performance pull-request-available
• Assignee: Attila Doroszlai
• Reporter: Tsz-wo Sze
• Created: 09/Oct/19 05:49
• Updated: 24/Feb/20 20:50
• Resolved: 06/Nov/19 09:11

Description

ContainerStateMachine:

• In loadSnapshot(..), it first reads the snapshotFile to a byte[] and then parses it to ContainerProtos.Container2BCSIDMapProto. The buffer copying can be avoided.

      try (FileInputStream fin = new FileInputStream(snapshotFile)) {
        byte[] container2BCSIDData = IOUtils.toByteArray(fin);
        ContainerProtos.Container2BCSIDMapProto proto =
            ContainerProtos.Container2BCSIDMapProto
                .parseFrom(container2BCSIDData);
        ...
      }
  

• persistContainerSet(..) has similar problem.

Issue Links

• links to: GitHub Pull Request #118