[HDDS-2261] Change readChunk methods to return ByteBuffer

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Labels: pull-request-available
• Assignee: István Fajth
• Reporter: István Fajth
• Created: 07/Oct/19 08:02
• Updated: 09/Oct/19 08:05
• Resolved: 09/Oct/19 08:05

Description

During refactoring to HDDS-2233 I realized the following:
KeyValueHandler.handleReadChunk and handleGetSmallFile methods are using ChunkManager.readChunk, which returns a byte[], but then both of them (the only usage points) converts the returning byte[] to a ByteBuffer, and then to a ByteString.
ChunkManagerImpl on the other hand in readChunk utilizes ChunkUtils.readChunk, which in order to conform the return value converts a ByteBuffer back to a byte[].

I open this JIRA to change the internal logic to fully rely on ByteBuffers instead of converting from ByteBuffer to byte[] then to ByteBuffer again.

Issue Links

• Is contained by: HDDS-2233 Remove ByteStringHelper and refactor the code to the place where it used
• is part of: HDDS-2233 Remove ByteStringHelper and refactor the code to the place where it used
• links to: GitHub Pull Request #1596