[HDDS-2259] Container Data Scrubber computes wrong checksum

• Type: Sub-task
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 0.5.0
• Fix Version/s: 0.5.0
• Component/s: Ozone Datanode
• Labels: pull-request-available
• Target Version/s: 0.5.0
• Assignee: Attila Doroszlai
• Reporter: Attila Doroszlai
• Created: 06/Oct/19 06:44
• Updated: 24/Feb/20 20:52
• Resolved: 07/Oct/19 21:37

Description

Chunk checksum verification fails for (almost) any file. This is caused by computing checksum for the entire buffer, regardless of the actual size of the chunk.

https://github.com/apache/hadoop/blob/55c5436f39120da0d7dabf43d7e5e6404307123b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainerCheck.java#L259-L273

            byte[] buffer = new byte[cData.getBytesPerChecksum()];
...
                v = fs.read(buffer);
...
                bytesRead += v;
...
                ByteString actual = cal.computeChecksum(buffer)
                    .getChecksums().get(0);

This results in marking all closed containers as unhealthy.

Issue Links

• links to: GitHub Pull Request #1605