[HDDS-2237] KeyDeletingService throws NPE if it's started too early

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.5.0
• Component/s: Ozone Manager
• Labels: pull-request-available
• Assignee: Marton Elek
• Reporter: Marton Elek
• Created: 03/Oct/19 15:17
• Updated: 09/Jun/20 18:30
• Resolved: 04/Oct/19 18:14

Description

1. OzoneManager starts KeyManager

2. KeyManager starts KeyDeletingService

3. KeyDeletingService uses OzoneManager.isLeader()

4. OzoneManager.isLeader() uses omRatisServer

5. omRatisServer can be null (bumm)

 

Now the initialization order in OzoneManager:

 

new KeymanagerServer() Includes start()!!!!

omRatisServer initialization

start() (includes KeyManager.start())

 

The solution seems to be easy: start the key manager only from the OzoneManager.start() and not from the OzoneManager.instantiateServices()

Issue Links

• links to: GitHub Pull Request #1584