Uploaded image for project: 'Apache Ozone'
  1. Apache Ozone
  2. HDDS-2157

checkstyle: print filenames relative to project root

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 0.5.0
    • build

    Description

      Currently checkstyle.sh prints files with violations using full path, eg:

      ...
      /workdir/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmMultipartUploadList.java
       23: Unused import - org.apache.hadoop.hdds.client.ReplicationType.
       24: Unused import - org.apache.hadoop.hdds.protocol.proto.HddsProtos.ReplicationFactor.
      /workdir/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmMultipartUploadListParts.java
       23: Unused import - org.apache.hadoop.hdds.protocol.proto.HddsProtos.ReplicationType.
      /workdir/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmMultipartKeyInfo.java
       19: Unused import - org.apache.hadoop.hdds.client.ReplicationFactor.
       20: Unused import - org.apache.hadoop.hdds.client.ReplicationType.
       26: Unused import - java.time.Instant.
      ...
      

      /workdir is specific to the CI environment. Similarly, local checkout directory is specific to each developer.

      Printing only path relative to project root (/workdir here) would make handling these paths easier (eg. reporting errors in JIRA or opening files locally for editing).

      Attachments

        Issue Links

          Activity

            People

              adoroszlai Attila Doroszlai
              adoroszlai Attila Doroszlai
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 50m
                  50m