[HDDS-2114] Rename does not preserve non-explicitly created interim directories

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 0.5.0
• Labels: pull-request-available
• Assignee: Lokesh Jain
• Reporter: István Fajth
• Created: 11/Sep/19 22:59
• Updated: 24/Feb/20 20:49
• Resolved: 17/Sep/19 05:28

Description

I am attaching a patch that adds a test that demonstrates the problem.

The scenario is coming from the way how Hive implements acid transactions with the ORC table format, but the test is redacted to the simplest possible code that reproduces the issue.

The scenario:

• Given a 3 level directory structure, where the top level directory was explicitly created, and the interim directory is implicitly created (for example either by creating a file with create("/top/interim/file") or by creating a directory with mkdirs("top/interim/dir"))
• When the leaf is moved out from the implicitly created directory making this directory an empty directory
• Then a FileNotFoundException is thrown when getFileStatus or listStatus is called on the interim directory.

The expected behaviour:

after the directory is becoming empty, the directory should still be part of the file system, moreover an empty FileStatus array should be returned when listStatus is called on it, and also a valid FileStatus object should be returned when getFileStatus is called on it.

 

 

As this issue is present with Hive, and as this is how a FileSystem is expected to work this seems to be an at least critical issue as I see, please feel free to change the priority if needed.

Also please note that, if the interim directory is explicitly created with mkdirs("top/interim") before creating the leaf, then the issue does not appear.

Issue Links

• links to: GitHub Pull Request #1440