[HDDS-1927] Consolidate add/remove Acl into OzoneAclUtil class

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.4.1
• Labels: pull-request-available
• Target Version/s: 0.4.1
• Assignee: Xiaoyu Yao
• Reporter: Bharat Viswanadham
• Created: 07/Aug/19 18:12
• Updated: 28/Aug/19 00:40
• Resolved: 28/Aug/19 00:32

Description

This Jira is created based on @xiaoyu comment on HDDS-1884

Can we abstract these add/remove logic into common AclUtil class as we can see similar logic in both bucket manager and key manager? For example,

public static boolean addAcl(List existingAcls, OzoneAcl newAcl)
public static boolean removeAcl(List existingAcls, OzoneAcl newAcl)

 

But to do this, we need both OmKeyInfo and OMBucketInfo to use list of OzoneAcl/OzoneAclInfo.

This Jira is to do that refactor, and also address above comment to move common logic to AclUtils.

Issue Links

• links to: GitHub Pull Request #1263
• links to: GitHub Pull Request #1353

Sub-Tasks

• Fix CreateBucket API in RpcClient: Open