[HDDS-1918] hadoop-ozone-tools has integration tests run as unit

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.4.1
• Fix Version/s: 0.5.0
• Component/s: build, test
• Labels: pull-request-available
• Assignee: Attila Doroszlai
• Reporter: Attila Doroszlai
• Created: 06/Aug/19 09:54
• Updated: 24/Feb/20 20:52
• Resolved: 07/Aug/19 00:01

Description

HDDS-1735 created separate test runner scripts for unit and integration tests.

Problem: hadoop-ozone-tools tests are currently run as part of the unit tests, but most of them start a MiniOzoneCluster, which is defined in hadoop-ozone-integration-test. Thus I think these tests are really integration tests, and should be run by integration.sh instead. There are currently only 3 real unit tests:

hadoop-ozone/tools/src/test/java/org/apache/hadoop/ozone/audit/parser/TestAuditParser.java
hadoop-ozone/tools/src/test/java/org/apache/hadoop/ozone/freon/TestProgressBar.java
hadoop-ozone/tools/src/test/java/org/apache/hadoop/ozone/genconf/TestGenerateOzoneRequiredConfigurations.java

hadoop-ozone-tools tests take ~6 minutes.

Possible solutions in order of increasing complexity:

1. Run hadoop-ozone-tools tests in integration.sh instead of unit.sh (This is similar to hadoop-ozone-filesystem, which is already run by integration.sh and has 2 real unit tests.)
2. Move all integration test classes to the hadoop-ozone-integration-test module, and make it depend on hadoop-ozone-tools and hadoop-ozone-filesystem instead of the other way around.
3. Rename integration test classes to *IT.java or IT*.java, add filters for Surefire runs.

Issue Links

• links to: GitHub Pull Request #1236