[HDDS-1888] Add containers to node2container map in SCM as part of ICR processing

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.5.0
• Component/s: SCM
• Labels: pull-request-available
• Target Version/s: 0.4.1
• Sprint: Done
• Assignee: Nandakumar
• Reporter: Nandakumar
• Created: 01/Aug/19 10:45
• Updated: 24/Feb/20 20:53
• Resolved: 08/Aug/19 09:55

Description

In SCM node2container and node2pipeline maps are managed by NodeManager and pipeline2container map is managed by PipelineManager.
Currently, when a container is allocated in SCM, it is added to pipeline2container map and we are not adding it to node2container map. We update the node2container map only when the datanode sends full container report.

When a node is marked as dead, DeadNodeHandler processes the event and it gets the list of containers that are hosted by the dead datanode and updates the respective container replica state in ContainerManager. The list of containers on the datanode is read from node2container map, this map will be missing containers which are created recently (after the last container report). In such cases we not be able to remove the container replica information for those containers. In reality, these containers are under replicated, but SCM will never know.

We should add containers to node2container map in SCM as soon as a container is allocated.

Issue Links

• is required by: HDDS-1906 TestScmSafeMode#testSCMSafeModeRestrictedOp is failing
• links to: GitHub Pull Request #1211