[HDDS-1863] Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.5.0
• Labels: pull-request-available
• Target Version/s: 0.5.0
• Assignee: Bharat Viswanadham
• Reporter: Bharat Viswanadham
• Created: 26/Jul/19 01:07
• Updated: 24/Feb/20 20:53
• Resolved: 08/Aug/19 22:40

Description

 

***************************************************
Status: Success
Git Base Revision: e97acb3bd8f3befd27418996fa5d4b50bf2e17bf
Number of Volumes created: 1
Number of Buckets created: 1
Number of Keys added: 1
Ratis replication factor: THREE
Ratis replication type: STAND_ALONE
Average Time spent in volume creation: 00:00:00,002
Average Time spent in bucket creation: 00:00:00,000
Average Time spent in key creation: 00:00:00,002
Average Time spent in key write: 00:00:00,101
Total bytes written: 0
Total Execution time: 00:00:05,699
 

***************************************************

[root@ozoneha-2 ozone-0.5.0-SNAPSHOT]# bin/ozone sh key list /vol-0-28271/bucket-0-95211

[

{   "version" : 0,   "md5hash" : null,   "createdOn" : "Fri, 26 Jul 2019 01:02:08 GMT",   "modifiedOn" : "Fri, 26 Jul 2019 01:02:09 GMT",   "size" : 36,   "keyName" : "key-0-98235",   "type" : null }

]

 

This is because of the below code in RandomKeyGenerator:

for (long nrRemaining = keySize - randomValue.length;
 nrRemaining > 0; nrRemaining -= bufferSize) {
 int curSize = (int) Math.min(bufferSize, nrRemaining);
 os.write(keyValueBuffer, 0, curSize);
}
os.write(randomValue);
os.close();

 

Issue Links

• links to: GitHub Pull Request #1167