[HDDS-1761] Fix class hierarchy for KeyRequest and FileRequest classes.

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.5.0
• Component/s: OM HA, Ozone Manager
• Labels: pull-request-available
• Assignee: Bharat Viswanadham
• Reporter: Bharat Viswanadham
• Created: 03/Jul/19 18:18
• Updated: 04/Jun/20 20:18
• Resolved: 16/Jul/19 00:53

Description

The patch looks mostly fine to me. A few minor comments. and one type error that needs to be fixed.

I would like to see the class hierarchy refactored in a follow up patch. OMFileCreateRequest}}should not extend {{OMKeyCreateRequest. Instead they should both extend an abstract class that encapsulates the common functionality.

Generally deriving from concrete classes is a bad idea.

 

This Jira is created based on arp comment during review of HDDS-1731

Issue Links

• links to: GitHub Pull Request #1052