[HDDS-1747] Support override of configuration annotations

• Type: Sub-task
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Target Version/s: 0.5.0
• Assignee: Unassigned
• Reporter: Marton Elek
• Created: 02/Jul/19 00:50
• Updated: 13/Dec/21 12:13

Description

To support HDDS-1744 we need a way to override existing configuration defaults. For example given a main HttpConfiguration:

public class OzoneHttpServerConfig {

  private int httpBindPort;

  @Config(key = "http-bind-port",
      defaultValue = "9874",
      description =
          "The actual port the web server will listen on for HTTP "
              + "communication. If the "
              + "port is 0 then the server will start on a free port.",
      tags = {ConfigTag.OM, ConfigTag.MANAGEMENT})
  public void setHttpBindPort(int httpBindPort) {
    this.httpBindPort = httpBindPort;
  }

We need an option to extend  this class and override the default value:

  @ConfigGroup(prefix = "hdds.datanode")
  public static class HttpConfig extends OzoneHttpServerConfig {

    @Override
    @ConfigOverride(defaultValue = "9882")
    public void setHttpBindPort(int httpBindPort) {
      super.setHttpBindPort(httpBindPort);
    }


  }

The expected behavior is a generated hdds.datanode.http-bind-port where the default is 9882.

Issue Links

• is blocked by: HDDS-1744 Improve BaseHttpServer to use typesafe configuration.