[HDDS-1355] Only FQDN is accepted for OM rpc address in secure environment

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.4.0
• Labels: pull-request-available
• Target Version/s: 0.4.0
• Assignee: Ajay Kumar
• Reporter: Marton Elek
• Created: 29/Mar/19 14:47
• Updated: 02/Apr/19 15:52
• Resolved: 02/Apr/19 15:51

Description

While the scm address can be a host name (relative to the current search domain) if the om address is just a hostname and not a FQDN a NPE is thrown:

  10   │   OZONE-SITE.XML_ozone.om.address: "om-0.om"
  11   │   OZONE-SITE.XML_ozone.scm.client.address: "scm-0.scm"
  12   │   OZONE-SITE.XML_ozone.scm.names: "scm-0.scm"

2019-03-29 14:37:52 ERROR OzoneManager:865 - Failed to start the OzoneManager.
java.lang.NullPointerException
    at org.apache.hadoop.ozone.om.OzoneManager.getSCMSignedCert(OzoneManager.java:1372)
    at org.apache.hadoop.ozone.om.OzoneManager.initializeSecurity(OzoneManager.java:1018)
    at org.apache.hadoop.ozone.om.OzoneManager.omInit(OzoneManager.java:971)
    at org.apache.hadoop.ozone.om.OzoneManager.createOm(OzoneManager.java:928)
    at org.apache.hadoop.ozone.om.OzoneManager.main(OzoneManager.java:859)

I don't know what is the right validation rule here, but I am pretty sure that NPE should be avoided and a meaningful error should be thrown. (and the behaviour should be the same for scm and om)

Issue Links

• links to: GitHub Pull Request #677