[HDDS-1153] Make tracing instrumentation configurable

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.4.1
• Labels: newbie pull-request-available
• Target Version/s: 0.5.0
• Sprint: Done
• Assignee: Kitti Nanasi
• Reporter: Marton Elek
• Created: 21/Feb/19 08:38
• Updated: 02/Oct/19 17:15
• Resolved: 02/Apr/19 12:34

Description

TracingUtil.createProxy is a helper method to create a proxy instance with tracing support.

The proxy instance implements the same interface as the original class and delegates all the method calls to the original instance but it also sends tracing information to the tracing server.

By default it's not a big overhead as the tracing libraries can be configured to send tracing only with some low probability.

But to make it more safe we can make it optional. With a global 'hdds.tracing.enabled' configuration variable (can be true by default) we can adjust the behavior of TracingUtil.createProxy.

If the tracing is disabled the TracingUtil.createProxy should return with the 'delegate' parameter instead of a proxy.

Issue Links

• relates to: HADOOP-15566 Support OpenTelemetry
• links to: GitHub Pull Request #673