[HDDS-1128] Create stateful manager class for the pipeline creation scheduling

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.4.1
• Target Version/s: 0.4.0
• Sprint: Done
• Assignee: Lokesh Jain
• Reporter: Marton Elek
• Created: 18/Feb/19 16:25
• Updated: 05/Aug/19 14:46
• Resolved: 13/Mar/19 11:19

Description

HDDS-1076 introduced a new static variable in RatisPipelineProvider: Scheduler. It seems to be a global variable which makes the testing harder.

shashikant also suggested to remove it:

It would be a good idea to move the scheduler Class Utility into some common utility package so that it can be used in multiple places as and when needed. 

I agree. And findbug also complains about it:

H D ST: Write to static field org.apache.hadoop.hdds.scm.pipeline.RatisPipelineProvider.scheduler from instance method new org.apache.hadoop.hdds.scm.pipeline.RatisPipelineProvider(NodeManager, PipelineStateManager, Configuration)  At RatisPipelineProvider.java:[line 56]

I think we need a new class which includes both the state of RatisPipelineUtils.isPipelineCreatorRunning and RaitsPipelineProvider.Scheduler. It should have one instance which is available for the classes which requires it.

Issue Links

• is duplicated by: HDDS-1140 TestSCMChillModeManager is failing with NullPointerException