Uploaded image for project: 'Hadoop Distributed Data Store'
  1. Hadoop Distributed Data Store
  2. HDDS-1128

Create stateful manager class for the pipeline creation scheduling

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.4.1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Sprint:
      HDDS Biscayne

      Description

      HDDS-1076 introduced a new static variable in RatisPipelineProvider: Scheduler. It seems to be a global variable which makes the testing harder.

      Shashikant Banerjee also suggested to remove it:

      It would be a good idea to move the scheduler Class Utility into some common utility package so that it can be used in multiple places as and when needed. 

      I agree. And findbug also complains about it:

      H D ST: Write to static field org.apache.hadoop.hdds.scm.pipeline.RatisPipelineProvider.scheduler from instance method new org.apache.hadoop.hdds.scm.pipeline.RatisPipelineProvider(NodeManager, PipelineStateManager, Configuration)  At RatisPipelineProvider.java:[line 56]

      I think we need a new class which includes both the state of RatisPipelineUtils.isPipelineCreatorRunning and RaitsPipelineProvider.Scheduler. It should have one instance which is available for the classes which requires it.

        Attachments

        1. HDDS-1128.001.patch
          36 kB
          Lokesh Jain
        2. HDDS-1128.002.patch
          48 kB
          Lokesh Jain
        3. HDDS-1128.003.patch
          51 kB
          Lokesh Jain

          Issue Links

            Activity

              People

              • Assignee:
                ljain Lokesh Jain
                Reporter:
                elek Marton Elek
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: