[HDDS-11119] Unnecessary UPDATE_VOLUME audit entry for DELETE_TENANT

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Component/s: Ozone Manager
• Labels: pull-request-available
• Assignee: Sumit Agrawal
• Reporter: Attila Doroszlai
• Created: 08/Jul/24 16:02
• Updated: 31/Jul/24 03:58
• Resolved: 31/Jul/24 03:58

Description

DELETE_TENANT request results in two audit messages. Problems:

• No information is logged about what change is made to the volume.
• The duplicate message is logged even if the request fails due to non-empty tenant, in which case volume update is not even attempted.

success

2024-07-08 15:47:31,680 | INFO  | OMAudit | user=testuser/[e-mail] | ip=192.168.112.5 | op=UPDATE_VOLUME {volume=tenantone} | ret=SUCCESS |  
2024-07-08 15:47:31,680 | INFO  | OMAudit | user=testuser/[e-mail] | ip=192.168.112.5 | op=DELETE_TENANT {tenant=tenantone} | ret=SUCCESS |  

failure

2024-07-08 15:47:24,325 | ERROR | OMAudit | user=testuser/[e-mail] | ip=192.168.112.5 | op=UPDATE_VOLUME {volume=tenantone} | ret=FAILURE | TENANT_NOT_EMPTY org.apache.hadoop.ozone.om.exceptions.OMException: Tenant 'tenantone' is not empty. All accessIds associated to this tenant must be revoked before the tenant can be deleted. See `ozone tenant user revoke`
	at org.apache.hadoop.ozone.om.request.s3.tenant.OMTenantDeleteRequest.validateAndUpdateCache(OMTenantDeleteRequest.java:158)
	at org.apache.hadoop.ozone.protocolPB.OzoneManagerRequestHandler.lambda$0(OzoneManagerRequestHandler.java:398) 
2024-07-08 15:47:24,325 | ERROR | OMAudit | user=testuser/[e-mail] | ip=192.168.112.5 | op=DELETE_TENANT {tenant=tenantone} | ret=FAILURE | TENANT_NOT_EMPTY org.apache.hadoop.ozone.om.exceptions.OMException: Tenant 'tenantone' is not empty. All accessIds associated to this tenant must be revoked before the tenant can be deleted. See `ozone tenant user revoke`
	at org.apache.hadoop.ozone.om.request.s3.tenant.OMTenantDeleteRequest.validateAndUpdateCache(OMTenantDeleteRequest.java:158)
	at org.apache.hadoop.ozone.protocolPB.OzoneManagerRequestHandler.lambda$0(OzoneManagerRequestHandler.java:398) 

Issue Links

• links to: GitHub Pull Request #6994