This came back up while adding a test in
I think there's value checking this in as-is because most tests need access to the metastore, which this simplifies and will let developers setup in a consistent way. The main reason for not moving createInputData is because I haven't looked into how most tests setup their data. If we can get this checked in I don't mind doing a refactoring pass to switch over the tests where this would make sense.
The reason this came up again is because the test I was running (HCatMapReduceTest) doesn't set the warehouse dir in the conf inside the test; this breaks adding the test in my IDE, which is much faster than running from the command line.
If checking this in sounds good I can update against trunk which is probably needed; also, if you want I can update the tests as part of adding this base class. Since there are a bunch perhaps I could do them in a small number of batches, since huge diffs are both hard to read and often are challenging to keep up-to-date against an active code base.