[HBASE-9992] [hbck] Refactor so that arbitrary -D cmdline options are included

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.96.0, 0.94.13
• Fix Version/s: 0.98.0, 0.96.1
• Component/s: hbck
• Hadoop Flags: Reviewed
• Assignee: Jonathan Hsieh
• Reporter: Jonathan Hsieh
• Created: 18/Nov/13 20:29
• Updated: 16/Dec/13 18:46
• Resolved: 23/Nov/13 19:41

Description

A review of HBASE-9831 pointed out the fact that -D options aren't being passed into the configuration object used by hbck. This means overriding -D options will not work unless special hooks are for specific options. A first attempt to fix this was in HBASE-9831 but it affected many other files.

The right approach would be to create a new HbckTool class that had the configured interface and change to existing HBaseFsck main to instantiate that to have it parse args, and then create the HBaseFsck object inside run.

Issue Links

• is related to: HBASE-9831 'hbasefsck.numthreads' property isn't passed to hbck via cmdline -D option