HBase
  1. HBase
  2. HBASE-9928

TestHRegion should clean up test-data directory upon completion

    Details

    • Type: Test Test
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.98.0, 0.99.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      TestHRegion leaves some files behind in hbase-server/target/test-data directory after tests complete.
      e.g. at the end of testRegionInfoFileCreation:

          // Verify that the .regioninfo file is still there
          assertTrue(HRegionFileSystem.REGION_INFO_FILE + " should be present in the region dir",
              fs.exists(new Path(regionDir, HRegionFileSystem.REGION_INFO_FILE)));
      

      test-data directory should be cleaned upon completion.

      I noticed this when looping TestHRegion in order to reproduce test failure.

      1. HBASE-9928.patch
        0.6 kB
        Gustavo Anatoly

        Activity

        Hide
        Ted Yu added a comment -

        +1, if tests pass.

        Show
        Ted Yu added a comment - +1, if tests pass.
        Hide
        Gustavo Anatoly added a comment -

        Okay Ted.

        Show
        Gustavo Anatoly added a comment - Okay Ted.
        Hide
        Jeffrey Zhong added a comment -

        The patch looks good(+1).

        Show
        Jeffrey Zhong added a comment - The patch looks good(+1).
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12618964/HBASE-9928.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 site. The patch appears to cause mvn site goal to fail.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.regionserver.TestSplitLogWorker

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8190//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8190//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8190//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8190//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8190//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8190//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8190//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8190//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8190//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8190//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8190//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12618964/HBASE-9928.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestSplitLogWorker Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8190//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8190//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8190//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8190//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8190//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8190//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8190//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8190//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8190//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8190//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8190//console This message is automatically generated.
        Hide
        Ted Yu added a comment -

        TestSplitLogWorker#testRescan failure was not related to the patch.

        Show
        Ted Yu added a comment - TestSplitLogWorker#testRescan failure was not related to the patch.
        Hide
        Ted Yu added a comment -

        Integrated to 0.98 and trunk.

        Thanks for the patch, Gustavo.

        Show
        Ted Yu added a comment - Integrated to 0.98 and trunk. Thanks for the patch, Gustavo.
        Hide
        Gustavo Anatoly added a comment -

        You're welcome.

        Show
        Gustavo Anatoly added a comment - You're welcome.
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #4729 (See https://builds.apache.org/job/HBase-TRUNK/4729/)
        HBASE-9928 TestHRegion should clean up test-data directory upon completion (tedyu: rev 1551406)

        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #4729 (See https://builds.apache.org/job/HBase-TRUNK/4729/ ) HBASE-9928 TestHRegion should clean up test-data directory upon completion (tedyu: rev 1551406) /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98 #16 (See https://builds.apache.org/job/HBase-0.98/16/)
        HBASE-9928 TestHRegion should clean up test-data directory upon completion (tedyu: rev 1551405)

        • /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #16 (See https://builds.apache.org/job/HBase-0.98/16/ ) HBASE-9928 TestHRegion should clean up test-data directory upon completion (tedyu: rev 1551405) /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #13 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/13/)
        HBASE-9928 TestHRegion should clean up test-data directory upon completion (tedyu: rev 1551405)

        • /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #13 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/13/ ) HBASE-9928 TestHRegion should clean up test-data directory upon completion (tedyu: rev 1551405) /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #9 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/9/)
        HBASE-9928 TestHRegion should clean up test-data directory upon completion (tedyu: rev 1551406)

        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #9 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/9/ ) HBASE-9928 TestHRegion should clean up test-data directory upon completion (tedyu: rev 1551406) /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java

          People

          • Assignee:
            Gustavo Anatoly
            Reporter:
            Ted Yu
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development