Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.98.0, 0.96.0
    • Fix Version/s: 0.98.0, 0.96.1
    • Component/s: Client, regionserver
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      It shows up in the profiling...

      1. 9886.v1.patch
        0.8 kB
        Nicolas Liochon

        Activity

        Hide
        Nicolas Liochon added a comment -

        v1: Advanced java code inside

        Show
        Nicolas Liochon added a comment - v1: Advanced java code inside
        Hide
        stack added a comment -

        +1

        Makes a difference?

        Show
        stack added a comment - +1 Makes a difference?
        Hide
        Nicolas Liochon added a comment -

        Not really sure
        But as it was cleaner anyway...

        Thanks for the review.

        Show
        Nicolas Liochon added a comment - Not really sure But as it was cleaner anyway... Thanks for the review.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12611961/9886.v1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 site. The patch appears to cause mvn site goal to fail.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.regionserver.TestHRegionBusyWait
        org.apache.hadoop.hbase.regionserver.TestHRegion

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7725//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7725//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7725//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7725//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7725//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7725//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7725//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7725//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7725//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7725//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7725//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12611961/9886.v1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestHRegionBusyWait org.apache.hadoop.hbase.regionserver.TestHRegion Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7725//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7725//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7725//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7725//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7725//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7725//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7725//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7725//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7725//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7725//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7725//console This message is automatically generated.
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #4667 (See https://builds.apache.org/job/HBase-TRUNK/4667/)
        HBASE-9886 Optimize ServerName#compareTo (nkeywal: rev 1538679)

        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerName.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #4667 (See https://builds.apache.org/job/HBase-TRUNK/4667/ ) HBASE-9886 Optimize ServerName#compareTo (nkeywal: rev 1538679) /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerName.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in hbase-0.96 #179 (See https://builds.apache.org/job/hbase-0.96/179/)
        HBASE-9886 Optimize ServerName#compareTo (nkeywal: rev 1538678)

        • /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerName.java
        Show
        Hudson added a comment - FAILURE: Integrated in hbase-0.96 #179 (See https://builds.apache.org/job/hbase-0.96/179/ ) HBASE-9886 Optimize ServerName#compareTo (nkeywal: rev 1538678) /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerName.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #826 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/826/)
        HBASE-9886 Optimize ServerName#compareTo (nkeywal: rev 1538679)

        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerName.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #826 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/826/ ) HBASE-9886 Optimize ServerName#compareTo (nkeywal: rev 1538679) /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerName.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in hbase-0.96-hadoop2 #113 (See https://builds.apache.org/job/hbase-0.96-hadoop2/113/)
        HBASE-9886 Optimize ServerName#compareTo (nkeywal: rev 1538678)

        • /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerName.java
        Show
        Hudson added a comment - FAILURE: Integrated in hbase-0.96-hadoop2 #113 (See https://builds.apache.org/job/hbase-0.96-hadoop2/113/ ) HBASE-9886 Optimize ServerName#compareTo (nkeywal: rev 1538678) /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerName.java
        Hide
        stack added a comment -

        Released in 0.96.1. Issue closed.

        Show
        stack added a comment - Released in 0.96.1. Issue closed.

          People

          • Assignee:
            Nicolas Liochon
            Reporter:
            Nicolas Liochon
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development