HBase
  1. HBase
  2. HBASE-9868

Remove some array copy, especially around protobuf

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.98.0, 0.96.0
    • Fix Version/s: 0.98.0, 0.96.1
    • Component/s: Client, Protobufs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Profiling the client shows that we're spending some time in array copy (10% of the code execution, 3% of the total time) in some array copy that we can avoid.

      1. 9868.v1.patch
        6 kB
        Nicolas Liochon
      2. 9868.trunk.v1.patch
        6 kB
        Nicolas Liochon
      3. 9868.v2.patch
        9 kB
        Nicolas Liochon
      4. 9868.v3.patch
        9 kB
        Nicolas Liochon

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12611424/9868.v1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7688//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12611424/9868.v1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7688//console This message is automatically generated.
        Hide
        Nicolas Liochon added a comment -

        Hum, it's a 0.96 patch, usually it works on trunk. Will double check later.

        Show
        Nicolas Liochon added a comment - Hum, it's a 0.96 patch, usually it works on trunk. Will double check later.
        Hide
        stack added a comment -

        Patch looks good. This stuff will clash w/ the patch over in HBASE-9867 (and I think what is in 9867 is 'safer' – but that we should probably add a byte array, offset, length op too)

        • valueBuilder.setQualifier(ByteString.copyFrom(kv.getQualifier()));
        • valueBuilder.setValue(ByteString.copyFrom(kv.getValue()));
          + valueBuilder.setQualifier(ByteString.copyFrom(
          + kv.getQualifierArray(), kv.getQualifierOffset(), kv.getQualifierLength()));
          + valueBuilder.setValue(ByteString.copyFrom(
          + kv.getValueArray(), kv.getValueOffset(), kv.getValueLength()));
        Show
        stack added a comment - Patch looks good. This stuff will clash w/ the patch over in HBASE-9867 (and I think what is in 9867 is 'safer' – but that we should probably add a byte array, offset, length op too) valueBuilder.setQualifier(ByteString.copyFrom(kv.getQualifier())); valueBuilder.setValue(ByteString.copyFrom(kv.getValue())); + valueBuilder.setQualifier(ByteString.copyFrom( + kv.getQualifierArray(), kv.getQualifierOffset(), kv.getQualifierLength())); + valueBuilder.setValue(ByteString.copyFrom( + kv.getValueArray(), kv.getValueOffset(), kv.getValueLength()));
        Hide
        stack added a comment -

        I'm looking at this stuff too. I wonder if some of Elliott's issue in client was just GCing. I have a 4G heap and running through 1M row cycles, I OOME at the 4th or 5th run w/ faked 1k servers and 100k regions. Looking for the root... If I were to guess it'd be the soft reference cache. Will report back.

        Show
        stack added a comment - I'm looking at this stuff too. I wonder if some of Elliott's issue in client was just GCing. I have a 4G heap and running through 1M row cycles, I OOME at the 4th or 5th run w/ faked 1k servers and 100k regions. Looking for the root... If I were to guess it'd be the soft reference cache. Will report back.
        Hide
        Nicolas Liochon added a comment -

        GCing

        I've seen it as well in my test. I'm profiling the client w/ 3 servers. I had no OOME, but it seems we're creating a lot of objects. Yourkit was telling me that the threads were blocked (so it's not only time or memory) in getCachedLocation.

        I wonder if we don't have more object since we protobuffed the client. We spend a lot of time there. Our MultiAction adds little value: if we want it to be efficient, we need to have the same structure as the protobuf message anyway so we don't abstract much.

        Show
        Nicolas Liochon added a comment - GCing I've seen it as well in my test. I'm profiling the client w/ 3 servers. I had no OOME, but it seems we're creating a lot of objects. Yourkit was telling me that the threads were blocked (so it's not only time or memory) in getCachedLocation. I wonder if we don't have more object since we protobuffed the client. We spend a lot of time there. Our MultiAction adds little value: if we want it to be efficient, we need to have the same structure as the protobuf message anyway so we don't abstract much.
        Hide
        stack added a comment -

        I don't see blockage (maybe my 'servers' are too friction-free being in essence /dev/nulls).

        I wonder if we don't have more object since we protobuffed the client.

        Probably. An exercise is bringing the pb higher up into the client (e.g. having Put be nought be a facade on the pb Put, etc.) and on the server removing the client-side objects altogether – Get/Put/etc – and instead use pb altogether; this should save a mountain of marshalling.

        Show
        stack added a comment - I don't see blockage (maybe my 'servers' are too friction-free being in essence /dev/nulls). I wonder if we don't have more object since we protobuffed the client. Probably. An exercise is bringing the pb higher up into the client (e.g. having Put be nought be a facade on the pb Put, etc.) and on the server removing the client-side objects altogether – Get/Put/etc – and instead use pb altogether; this should save a mountain of marshalling.
        Hide
        Nicolas Liochon added a comment -

        I don't see blockage (maybe my 'servers' are too friction-free being in essence /dev/nulls).

        I see it in "public synchronized V lowerValueByKey". It's with a real cluster, but there are a lot of region and the i/o are good, so don't have any retry.

        Show
        Nicolas Liochon added a comment - I don't see blockage (maybe my 'servers' are too friction-free being in essence /dev/nulls). I see it in "public synchronized V lowerValueByKey". It's with a real cluster, but there are a lot of region and the i/o are good, so don't have any retry.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12611454/9868.trunk.v1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 site. The patch appears to cause mvn site goal to fail.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7690//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7690//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7690//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7690//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7690//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7690//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7690//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7690//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7690//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7690//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7690//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12611454/9868.trunk.v1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7690//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7690//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7690//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7690//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7690//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7690//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7690//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7690//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7690//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7690//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7690//console This message is automatically generated.
        Hide
        Nicolas Liochon added a comment -

        v2 takes into account the changes in HBASE-9867.
        I also removed two protobuf builder object creation in a loop. We've got a bunch of work in this area ahead of us. Likely removing the class-in-the-middle and use differently the builder pattern is the way to go...

        Show
        Nicolas Liochon added a comment - v2 takes into account the changes in HBASE-9867 . I also removed two protobuf builder object creation in a loop. We've got a bunch of work in this area ahead of us. Likely removing the class-in-the-middle and use differently the builder pattern is the way to go...
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12611580/9868.v3.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 site. The patch appears to cause mvn site goal to fail.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7701//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7701//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12611580/9868.v3.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7701//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7701//console This message is automatically generated.
        Hide
        stack added a comment -

        +1

        Nice.

        Show
        stack added a comment - +1 Nice.
        Hide
        stack added a comment -

        Committed to 0.96 and trunk (It is friday evening in Paris and I want to run w/ this fix in tests today). Nice one Nicolas Liochon

        Show
        stack added a comment - Committed to 0.96 and trunk (It is friday evening in Paris and I want to run w/ this fix in tests today). Nice one Nicolas Liochon
        Hide
        Hudson added a comment -

        FAILURE: Integrated in hbase-0.96 #177 (See https://builds.apache.org/job/hbase-0.96/177/)
        HBASE-9868 Remove some array copy, especially around protobuf (stack: rev 1537989)

        • /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
        • /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
        • /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Put.java
        • /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/BigDecimalColumnInterpreter.java
        • /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
        • /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
        • /hbase/branches/0.96/hbase-protocol/src/main/java/com/google/protobuf/ZeroCopyLiteralByteString.java
        • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java
        Show
        Hudson added a comment - FAILURE: Integrated in hbase-0.96 #177 (See https://builds.apache.org/job/hbase-0.96/177/ ) HBASE-9868 Remove some array copy, especially around protobuf (stack: rev 1537989) /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Put.java /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/BigDecimalColumnInterpreter.java /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java /hbase/branches/0.96/hbase-protocol/src/main/java/com/google/protobuf/ZeroCopyLiteralByteString.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK #4664 (See https://builds.apache.org/job/HBase-TRUNK/4664/)
        HBASE-9868 Remove some array copy, especially around protobuf (stack: rev 1537988)

        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Put.java
        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/BigDecimalColumnInterpreter.java
        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
        • /hbase/trunk/hbase-protocol/src/main/java/com/google/protobuf/ZeroCopyLiteralByteString.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #4664 (See https://builds.apache.org/job/HBase-TRUNK/4664/ ) HBASE-9868 Remove some array copy, especially around protobuf (stack: rev 1537988) /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Put.java /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/BigDecimalColumnInterpreter.java /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java /hbase/trunk/hbase-protocol/src/main/java/com/google/protobuf/ZeroCopyLiteralByteString.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in hbase-0.96-hadoop2 #111 (See https://builds.apache.org/job/hbase-0.96-hadoop2/111/)
        HBASE-9868 Remove some array copy, especially around protobuf (stack: rev 1537989)

        • /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
        • /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
        • /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Put.java
        • /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/BigDecimalColumnInterpreter.java
        • /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
        • /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
        • /hbase/branches/0.96/hbase-protocol/src/main/java/com/google/protobuf/ZeroCopyLiteralByteString.java
        • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java
        Show
        Hudson added a comment - FAILURE: Integrated in hbase-0.96-hadoop2 #111 (See https://builds.apache.org/job/hbase-0.96-hadoop2/111/ ) HBASE-9868 Remove some array copy, especially around protobuf (stack: rev 1537989) /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Put.java /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/BigDecimalColumnInterpreter.java /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java /hbase/branches/0.96/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java /hbase/branches/0.96/hbase-protocol/src/main/java/com/google/protobuf/ZeroCopyLiteralByteString.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #823 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/823/)
        HBASE-9868 Remove some array copy, especially around protobuf (stack: rev 1537988)

        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Put.java
        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/BigDecimalColumnInterpreter.java
        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
        • /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
        • /hbase/trunk/hbase-protocol/src/main/java/com/google/protobuf/ZeroCopyLiteralByteString.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #823 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/823/ ) HBASE-9868 Remove some array copy, especially around protobuf (stack: rev 1537988) /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Put.java /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/BigDecimalColumnInterpreter.java /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java /hbase/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java /hbase/trunk/hbase-protocol/src/main/java/com/google/protobuf/ZeroCopyLiteralByteString.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java
        Hide
        stack added a comment -

        Released in 0.96.1. Issue closed.

        Show
        stack added a comment - Released in 0.96.1. Issue closed.

          People

          • Assignee:
            Nicolas Liochon
            Reporter:
            Nicolas Liochon
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development