Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: 0.94.3
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Backport HBASE-9605 which is about "Allow AggregationClient to skip specifying column family for row count aggregate"

        Activity

        Hide
        chendihao added a comment -

        patch for 0.94

        Show
        chendihao added a comment - patch for 0.94
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12610076/HBASE-9830-0.94-v1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7614//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12610076/HBASE-9830-0.94-v1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7614//console This message is automatically generated.
        Hide
        chendihao added a comment -

        The patch is for 0.94 so HadoopQA may not handle it. Hope someone review and commit it.

        Show
        chendihao added a comment - The patch is for 0.94 so HadoopQA may not handle it. Hope someone review and commit it.
        Hide
        chendihao added a comment -

        Ted Yu Any suggestions?

        Show
        chendihao added a comment - Ted Yu Any suggestions?
        Hide
        Jean-Marc Spaggiari added a comment -

        Lars Hofhansl can you have a look?

        Show
        Jean-Marc Spaggiari added a comment - Lars Hofhansl can you have a look?
        Hide
        Ted Yu added a comment -

        TestAggregateProtocol passes with patch.

        +1

        Show
        Ted Yu added a comment - TestAggregateProtocol passes with patch. +1
        Hide
        Lars Hofhansl added a comment -

        If it's in 0.94 it should go into 0.96 as well (I guess).

        Show
        Lars Hofhansl added a comment - If it's in 0.94 it should go into 0.96 as well (I guess).
        Hide
        chendihao added a comment -

        Agree with Lars Hofhansl. Because we use 0.94 and need coprocessor to count rows, it may be same for the 0.96 guys if they need.

        Show
        chendihao added a comment - Agree with Lars Hofhansl . Because we use 0.94 and need coprocessor to count rows, it may be same for the 0.96 guys if they need.
        Hide
        Lars Hofhansl added a comment -

        stack, if you're not opposed, let's put it into 0.96 as well.

        Show
        Lars Hofhansl added a comment - stack , if you're not opposed, let's put it into 0.96 as well.
        Hide
        Lars Hofhansl added a comment -

        Targeting to 0.94.15 for now.

        Show
        Lars Hofhansl added a comment - Targeting to 0.94.15 for now.
        Hide
        stack added a comment -

        I don't think 0.96 has Aggregation CP Lars Hofhansl. It was removed so bigtop could compile. Maybe I should put it back?

        Show
        stack added a comment - I don't think 0.96 has Aggregation CP Lars Hofhansl . It was removed so bigtop could compile. Maybe I should put it back?
        Hide
        Lars Hofhansl added a comment -

        Trunk has it and 0.94 has it, though? That's weird.

        Show
        Lars Hofhansl added a comment - Trunk has it and 0.94 has it, though? That's weird.
        Hide
        Lars Hofhansl added a comment -

        Confusion about whether this is in 0.96. Moving to next month for now.

        Show
        Lars Hofhansl added a comment - Confusion about whether this is in 0.96. Moving to next month for now.
        Hide
        Lars Hofhansl added a comment -

        It would be a slight behavioral change in 0.94. You need this in 0.94 chendihao?

        Show
        Lars Hofhansl added a comment - It would be a slight behavioral change in 0.94. You need this in 0.94 chendihao ?
        Hide
        chendihao added a comment -

        Lars Hofhansl Yes, we need this. We're using coprocessor to count the rows but with this restriction we have to indicate all the cf. Fixing this would help to process any cluster with the same interface.

        Show
        chendihao added a comment - Lars Hofhansl Yes, we need this. We're using coprocessor to count the rows but with this restriction we have to indicate all the cf. Fixing this would help to process any cluster with the same interface.
        Hide
        Lars Hofhansl added a comment -

        Can't really put it in 0.94 if 0.96 does not also have it. stack, what do you think?

        Show
        Lars Hofhansl added a comment - Can't really put it in 0.94 if 0.96 does not also have it. stack , what do you think?
        Hide
        Lars Hofhansl added a comment -

        .bq I don't think 0.96 has Aggregation CP Lars Hofhansl. It was removed so bigtop could compile. Maybe I should put it back?
        Are you sure it's gone from 0.96 only? I.e. 0.94 has it and 0.98 has it. That would be weird. Let's check and close this one.

        Show
        Lars Hofhansl added a comment - .bq I don't think 0.96 has Aggregation CP Lars Hofhansl. It was removed so bigtop could compile. Maybe I should put it back? Are you sure it's gone from 0.96 only? I.e. 0.94 has it and 0.98 has it. That would be weird. Let's check and close this one.
        Hide
        stack added a comment -

        Lars Hofhansl Removing aggregation was only way I could make hbase trunk work on bigtop. Bigtop would fail compile in a way that Roman and I could not figure. Undoing it freed us up but then we didn't go much further than a compile...

        Show
        stack added a comment - Lars Hofhansl Removing aggregation was only way I could make hbase trunk work on bigtop. Bigtop would fail compile in a way that Roman and I could not figure. Undoing it freed us up but then we didn't go much further than a compile...
        Hide
        Lars Hofhansl added a comment -

        But it's back in 0.98? (Sorry if I'm dense about it)

        Show
        Lars Hofhansl added a comment - But it's back in 0.98? (Sorry if I'm dense about it)
        Hide
        Lars Hofhansl added a comment -

        There's too much confusion here. I am removing this from 0.94.
        Let me know if this important, we can bring it back.

        Show
        Lars Hofhansl added a comment - There's too much confusion here. I am removing this from 0.94. Let me know if this important, we can bring it back.

          People

          • Assignee:
            chendihao
            Reporter:
            chendihao
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development