HBase
  1. HBase
  2. HBASE-9725

lost brackets for createMethodTimeMetrics?

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Thrift
    • Labels:
      None

      Description

      to me, seems lost brackets for createMethodTimeMetrics

        Activity

        Hide
        Liang Xie added a comment -
          private void createMetricsForMethods(Class<?> iface) {
            LOG.debug("Creating metrics for interface " + iface.toString());
            for (Method m : iface.getDeclaredMethods()) {
              if (getMethodTimeMetrics(m.getName()) == null)
                LOG.debug("Creating metrics for method:" + m.getName());
                createMethodTimeMetrics(m.getName());
            }
          }
        

        should be

          private void createMetricsForMethods(Class<?> iface) {
            LOG.debug("Creating metrics for interface " + iface.toString());
            for (Method m : iface.getDeclaredMethods()) {
              if (getMethodTimeMetrics(m.getName()) == null) {
                LOG.debug("Creating metrics for method:" + m.getName());
                createMethodTimeMetrics(m.getName());
              }
            }
          }
        
        Show
        Liang Xie added a comment - private void createMetricsForMethods( Class <?> iface) { LOG.debug( "Creating metrics for interface " + iface.toString()); for (Method m : iface.getDeclaredMethods()) { if (getMethodTimeMetrics(m.getName()) == null ) LOG.debug( "Creating metrics for method:" + m.getName()); createMethodTimeMetrics(m.getName()); } } should be private void createMetricsForMethods( Class <?> iface) { LOG.debug( "Creating metrics for interface " + iface.toString()); for (Method m : iface.getDeclaredMethods()) { if (getMethodTimeMetrics(m.getName()) == null ) { LOG.debug( "Creating metrics for method:" + m.getName()); createMethodTimeMetrics(m.getName()); } } }
        Hide
        Liang Xie added a comment -

        attached is trivial patch against 0.94 branch. there's lots of code refactoring on trunk, seems no need to modify trunk code.

        Show
        Liang Xie added a comment - attached is trivial patch against 0.94 branch. there's lots of code refactoring on trunk, seems no need to modify trunk code.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12607340/HBASE-9725-0.94.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7496//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12607340/HBASE-9725-0.94.txt against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7496//console This message is automatically generated.
        Hide
        Andrew Purtell added a comment -

        Resolve this? As invalid?

        Show
        Andrew Purtell added a comment - Resolve this? As invalid?

          People

          • Assignee:
            Liang Xie
            Reporter:
            Liang Xie
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:

              Development