[HBASE-9589] Bytes#LexicographicalComparerHolder#UnsafeComparer#compareTo() has dead code

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Not A Problem
• Assignee: Unassigned
• Reporter: Ted Yu
• Created: 19/Sep/13 23:34
• Updated: 16/Jun/22 18:08
• Resolved: 18/Oct/13 20:38

Description

Starting with line 1177:

          if (diff != 0) {
            if (!littleEndian) {
              return lessThanUnsigned(lw, rw) ? -1 : 1;
            }

            // Use binary search
            int n = 0;
            int y;
            int x = (int) diff;
            if (x == 0) {
              x = (int) (diff >>> 32);

The value of "x" cannot be equal to 0.