HBase
  1. HBase
  2. HBASE-9441

Intermittent TestRegionPlacement#testRegionPlacement failure

    Details

    • Type: Test Test
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.98.0, 0.96.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Occasionally TestRegionPlacement#testRegionPlacement fails due to no region found on secondary / tertiary region server.
      In the following test output, 10359edcfb1a761f94ab6d5b559c2278 was the region from the killed region server:

      2013-09-04 23:28:25,127 INFO  [pool-1-thread-1] util.FSUtils(1878): Scan DFS for locality info takes 38 ms
      Region Assignment Verification for Table: testRegionAssignment
              Total regions : 10
              Total regions on favored nodes 10
                      Total regions on PRIMARY region servers: 10
                      Total regions on SECONDARY region servers: 0
                      Total regions on TERTIARY region servers: 0
      ...
      2013-09-04 23:28:25,130 DEBUG [pool-1-thread-1-EventThread] zookeeper.ZooKeeperWatcher(312): master:37502-0x140eb4dc4ef0000 Received ZooKeeper Event, type=NodeDataChanged, state=SyncConnected, path=/hbase/region-in-transition/10359edcfb1a761f94ab6d5b559c2278
      2013-09-04 23:28:25,130 DEBUG [RS_OPEN_REGION-kiyo:49841-1] zookeeper.ZKAssign(861): regionserver:49841-0x140eb4dc4ef0007 Transitioned node 10359edcfb1a761f94ab6d5b559c2278 from RS_ZK_REGION_OPENING to RS_ZK_REGION_OPENED
      2013-09-04 23:28:25,131 DEBUG [RS_OPEN_REGION-kiyo:49841-1] handler.OpenRegionHandler(386): Transitioned 10359edcfb1a761f94ab6d5b559c2278 to OPENED in zk on kiyo.gq1.ygridcore.net,49841,1378337278470
      2013-09-04 23:28:25,131 DEBUG [RS_OPEN_REGION-kiyo:49841-1] handler.OpenRegionHandler(187): Opened hbase:namespace,,1378337284888.10359edcfb1a761f94ab6d5b559c2278. on kiyo.gq1.ygridcore.net,49841,1378337278470
      2013-09-04 23:28:25,132 DEBUG [AM.ZK.Worker-pool2-t6] master.AssignmentManager(801): Handling transition=RS_ZK_REGION_OPENED, server=kiyo.gq1.ygridcore.net,49841,1378337278470, region=10359edcfb1a761f94ab6d5b559c2278, current state from region state map ={10359edcfb1a761f94ab6d5b559c2278 state=OPENING, ts=1378337305025, server=kiyo.gq1.ygridcore.net,49841,1378337278470}
      2013-09-04 23:28:25,132 INFO  [AM.ZK.Worker-pool2-t6] master.RegionStates(263): Transitioned from {10359edcfb1a761f94ab6d5b559c2278 state=OPENING, ts=1378337305025, server=kiyo.gq1.ygridcore.net,49841,1378337278470} to {10359edcfb1a761f94ab6d5b559c2278 state=OPEN, ts=1378337305132, server=kiyo.gq1.ygridcore.net,49841,1378337278470}
      2013-09-04 23:28:25,132 DEBUG [AM.ZK.Worker-pool2-t6] handler.OpenedRegionHandler(150): Handling OPENED event for 10359edcfb1a761f94ab6d5b559c2278 from kiyo.gq1.ygridcore.net,49841,1378337278470; deleting unassigned node
      2013-09-04 23:28:25,132 DEBUG [AM.ZK.Worker-pool2-t6] zookeeper.ZKAssign(405): master:37502-0x140eb4dc4ef0000 Deleting existing unassigned node 10359edcfb1a761f94ab6d5b559c2278 in expected state RS_ZK_REGION_OPENED
      2013-09-04 23:28:25,188 INFO  [pool-1-thread-1] hbase.ResourceChecker(171): after: master.TestRegionPlacement#testRegionPlacement Thread=873 (was 814)
      Potentially hanging thread: RS_OPEN_REGION-kiyo:53373-2
      ...
       - Thread LEAK? -, OpenFileDescriptor=1061 (was 1033) - OpenFileDescriptor LEAK? -, MaxFileDescriptor=32768 (was 32768), SystemLoadAverage=549 (was 609), ProcessCount=489 (was 489), AvailableMemoryMB=9288 (was 9107) - AvailableMemoryMB LEAK? -, ConnectionCount=23 (was 22) - ConnectionCount LEAK? -
      2013-09-04 23:28:25,189 WARN  [pool-1-thread-1] hbase.ResourceChecker(134): Thread=873 is superior to 500
      2013-09-04 23:28:25,190 WARN  [pool-1-thread-1] hbase.ResourceChecker(134): OpenFileDescriptor=1061 is superior to 1024
      2013-09-04 23:28:25,223 DEBUG [pool-1-thread-1-EventThread] zookeeper.ZooKeeperWatcher(312): master:37502-0x140eb4dc4ef0000 Received ZooKeeper Event, type=NodeDeleted, state=SyncConnected, path=/hbase/region-in-transition/10359edcfb1a761f94ab6d5b559c2278
      2013-09-04 23:28:25,224 DEBUG [pool-1-thread-1-EventThread] zookeeper.ZooKeeperWatcher(312): master:37502-0x140eb4dc4ef0000 Received ZooKeeper Event, type=NodeChildrenChanged, state=SyncConnected, path=/hbase/region-in-transition
      2013-09-04 23:28:25,224 DEBUG [AM.ZK.Worker-pool2-t6] zookeeper.ZKAssign(434): master:37502-0x140eb4dc4ef0000 Deleted unassigned node 10359edcfb1a761f94ab6d5b559c2278 in expected state RS_ZK_REGION_OPENED
      2013-09-04 23:28:25,225 DEBUG [AM.ZK.Worker-pool2-t6] master.AssignmentManager$4(1276): Znode hbase:namespace,,1378337284888.10359edcfb1a761f94ab6d5b559c2278. deleted, state: {10359edcfb1a761f94ab6d5b559c2278 state=OPEN, ts=1378337305132, server=kiyo.gq1.ygridcore.net,49841,1378337278470}
      2013-09-04 23:28:25,225 INFO  [AM.ZK.Worker-pool2-t6] master.RegionStates(299): Onlined 10359edcfb1a761f94ab6d5b559c2278 on kiyo.gq1.ygridcore.net,49841,1378337278470
      

      Looks like region placement report was obtained when the region was still in transition.

      1. 9441-v1.txt
        3 kB
        Ted Yu
      2. org.apache.hadoop.hbase.master.TestRegionPlacement-output.txt
        402 kB
        Ted Yu
      3. 9441-v2.txt
        5 kB
        Ted Yu
      4. 9441-v3.txt
        4 kB
        Ted Yu
      5. 9441-v4.txt
        5 kB
        Ted Yu
      6. 9441-v5.txt
        6 kB
        Ted Yu
      7. 9441-v6.txt
        5 kB
        Ted Yu

        Activity

        Hide
        Ted Yu added a comment -

        Patch v1 waits for region transition to complete before obtaining region placement report.

        Show
        Ted Yu added a comment - Patch v1 waits for region transition to complete before obtaining region placement report.
        Hide
        Devaraj Das added a comment -

        Ted Yu, can you please upload the full test log if available. Thanks.

        Show
        Devaraj Das added a comment - Ted Yu , can you please upload the full test log if available. Thanks.
        Hide
        Ted Yu added a comment -

        Here it is.

        Show
        Ted Yu added a comment - Here it is.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12601526/9441-v1.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7043//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7043//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7043//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7043//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7043//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7043//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7043//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7043//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7043//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7043//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12601526/9441-v1.txt against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7043//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7043//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7043//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7043//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7043//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7043//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7043//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7043//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7043//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7043//console This message is automatically generated.
        Hide
        Devaraj Das added a comment -

        Ted Yu, I'd suggest you move the ZK related code to the place where there is a check like

        while (curr - orig < regionsToVerify.size()) {

        . You can then remove that while loop.

        Show
        Devaraj Das added a comment - Ted Yu , I'd suggest you move the ZK related code to the place where there is a check like while (curr - orig < regionsToVerify.size()) { . You can then remove that while loop.
        Hide
        Ted Yu added a comment -

        Patch v2 replaces the while loop with ZKAssign.blockUntilNoRIT(zkw) call.

        Show
        Ted Yu added a comment - Patch v2 replaces the while loop with ZKAssign.blockUntilNoRIT(zkw) call.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12601686/9441-v3.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.master.TestRegionPlacement
        org.apache.hadoop.hbase.master.TestDistributedLogSplitting

        -1 core zombie tests. There are 1 zombie test(s): at org.apache.hadoop.hbase.util.TestHBaseFsck.testLingeringReferenceFile(TestHBaseFsck.java:1832)

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7060//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7060//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12601686/9441-v3.txt against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.master.TestRegionPlacement org.apache.hadoop.hbase.master.TestDistributedLogSplitting -1 core zombie tests . There are 1 zombie test(s): at org.apache.hadoop.hbase.util.TestHBaseFsck.testLingeringReferenceFile(TestHBaseFsck.java:1832) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7060//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7060//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12601713/9441-v4.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.master.TestDistributedLogSplitting

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7063//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7063//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7063//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7063//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7063//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7063//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7063//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7063//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7063//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7063//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12601713/9441-v4.txt against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.master.TestDistributedLogSplitting Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7063//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7063//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7063//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7063//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7063//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7063//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7063//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7063//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7063//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7063//console This message is automatically generated.
        Hide
        Ted Yu added a comment -

        The javadoc warning is not related to this patch:

        [WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java:1693: warning - @param argument "regionName" is not a parameter name.
        
        Show
        Ted Yu added a comment - The javadoc warning is not related to this patch: [WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java:1693: warning - @param argument "regionName" is not a parameter name.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12601765/9441-v5.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 site. The patch appears to cause mvn site goal to fail.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.master.TestDistributedLogSplitting

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7066//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7066//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7066//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7066//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7066//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7066//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7066//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7066//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7066//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7066//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12601765/9441-v5.txt against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.master.TestDistributedLogSplitting Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7066//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7066//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7066//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7066//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7066//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7066//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7066//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7066//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7066//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7066//console This message is automatically generated.
        Hide
        Devaraj Das added a comment -

        +1 (although now that you don't kill RS with the namespace region, the wait for RIT is not needed. The while loop will cover that).

        Show
        Devaraj Das added a comment - +1 (although now that you don't kill RS with the namespace region, the wait for RIT is not needed. The while loop will cover that).
        Hide
        Ted Yu added a comment -

        Patch v6 addresses Devaraj's review comments.

        Show
        Ted Yu added a comment - Patch v6 addresses Devaraj's review comments.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12601869/9441-v6.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7072//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7072//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12601869/9441-v6.txt against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7072//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7072//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7072//console This message is automatically generated.
        Hide
        Ted Yu added a comment -

        Integrated to trunk.

        Thanks for the review.

        Show
        Ted Yu added a comment - Integrated to trunk. Thanks for the review.
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK #4477 (See https://builds.apache.org/job/HBase-TRUNK/4477/)
        HBASE-9441 Intermittent TestRegionPlacement#testRegionPlacement failure (tedyu: rev 1520671)

        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #4477 (See https://builds.apache.org/job/HBase-TRUNK/4477/ ) HBASE-9441 Intermittent TestRegionPlacement#testRegionPlacement failure (tedyu: rev 1520671) /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement.java
        Hide
        stack added a comment -

        +1 for 0.96 branch please.

        Show
        stack added a comment - +1 for 0.96 branch please.
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #715 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/715/)
        HBASE-9441 Intermittent TestRegionPlacement#testRegionPlacement failure (tedyu: rev 1520671)

        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #715 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/715/ ) HBASE-9441 Intermittent TestRegionPlacement#testRegionPlacement failure (tedyu: rev 1520671) /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement.java
        Hide
        Ted Yu added a comment -

        Integrated to 0.96 as well.

        Show
        Ted Yu added a comment - Integrated to 0.96 as well.
        Hide
        Hudson added a comment -

        FAILURE: Integrated in hbase-0.96 #26 (See https://builds.apache.org/job/hbase-0.96/26/)
        HBASE-9441 Intermittent TestRegionPlacement#testRegionPlacement failure (tedyu: rev 1521278)

        • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement.java
        Show
        Hudson added a comment - FAILURE: Integrated in hbase-0.96 #26 (See https://builds.apache.org/job/hbase-0.96/26/ ) HBASE-9441 Intermittent TestRegionPlacement#testRegionPlacement failure (tedyu: rev 1521278) /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in hbase-0.96-hadoop2 #14 (See https://builds.apache.org/job/hbase-0.96-hadoop2/14/)
        HBASE-9441 Intermittent TestRegionPlacement#testRegionPlacement failure (tedyu: rev 1521278)

        • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement.java
        Show
        Hudson added a comment - SUCCESS: Integrated in hbase-0.96-hadoop2 #14 (See https://builds.apache.org/job/hbase-0.96-hadoop2/14/ ) HBASE-9441 Intermittent TestRegionPlacement#testRegionPlacement failure (tedyu: rev 1521278) /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRegionPlacement.java

          People

          • Assignee:
            Ted Yu
            Reporter:
            Ted Yu
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development