HBase
  1. HBase
  2. HBASE-9435

Fix jersey serialization/deserialization of json objects

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.98.0, 0.96.0
    • Component/s: REST
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      This patch replaces the default jersey json marshaller/unmarshaller with jackson. It updates unit tests to include json serialization/deserialization verification.

      The patch is backward compatible except for the following:

      StorageClusterStatusModel, which is broken and had to be fixed in this patch. It only shows one node in the liveNodes field.

      Previously when submitting requests represented in json, some fields prefixed with the '@' sign were accepted as equivalent to the same field name without the prefix. This was unintended and likely caused by a bug in Jersey. This has been rectified and no longer supported. It should be noted that responses represented in json remain the same (no '@' prefix).
      Show
      This patch replaces the default jersey json marshaller/unmarshaller with jackson. It updates unit tests to include json serialization/deserialization verification. The patch is backward compatible except for the following: StorageClusterStatusModel, which is broken and had to be fixed in this patch. It only shows one node in the liveNodes field. Previously when submitting requests represented in json, some fields prefixed with the '@' sign were accepted as equivalent to the same field name without the prefix. This was unintended and likely caused by a bug in Jersey. This has been rectified and no longer supported. It should be noted that responses represented in json remain the same (no '@' prefix).

      Description

      Stargate uses the default json marshaller/unmarshaller in natural mode. In this mode the unmarshaller has trouble unmarshalling json instances.

      This patch fixes this issue by using jackson as the marshaller/unmarshaller instead.

      I've also updated all the model unit tests to test json serialization/deserialization. Backwards compatibilty can be verified by modify the test base class to use the original marshaller/unmarshaller and see that model tests pass.

      The patch is backward compatible except for StorageClusterStatusModel, which is broken anyway. It only shows one node in the liveNodes field.

      1. HBASE-9435.patch
        69 kB
        stack
      2. HBASE-9435.patch
        69 kB
        Francis Liu

        Issue Links

          Activity

          Hide
          Nick Dimiduk added a comment -

          The JSON peculiarities have bitten me in the past, so I'm in favor of this change.

          Read through the patch, things look good to me. I'm not familiar with the intimate differences between Jersey and Jackson. +1

          Show
          Nick Dimiduk added a comment - The JSON peculiarities have bitten me in the past, so I'm in favor of this change. Read through the patch, things look good to me. I'm not familiar with the intimate differences between Jersey and Jackson. +1
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12601407/HBASE-9435.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 44 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:

          -1 core zombie tests. There are 1 zombie test(s): at org.apache.hadoop.hbase.TestZooKeeper.testRegionAssignmentAfterMasterRecoveryDueToZKExpiry(TestZooKeeper.java:486)

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7029//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7029//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7029//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7029//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7029//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7029//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7029//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7029//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7029//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7029//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12601407/HBASE-9435.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 44 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: -1 core zombie tests . There are 1 zombie test(s): at org.apache.hadoop.hbase.TestZooKeeper.testRegionAssignmentAfterMasterRecoveryDueToZKExpiry(TestZooKeeper.java:486) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7029//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7029//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7029//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7029//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7029//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7029//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7029//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7029//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7029//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7029//console This message is automatically generated.
          Hide
          Andrew Purtell added a comment -

          Backwards compatibilty can be verified by modify the test base class to use the original marshaller/unmarshaller and see that model tests pass.

          +1 with this.

          Using Jackson will be a big improvement.

          Show
          Andrew Purtell added a comment - Backwards compatibilty can be verified by modify the test base class to use the original marshaller/unmarshaller and see that model tests pass. +1 with this. Using Jackson will be a big improvement.
          Hide
          stack added a comment -

          Rerun test to see if test failure a transient.

          Show
          stack added a comment - Rerun test to see if test failure a transient.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12601488/HBASE-9435.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 44 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.io.hfile.TestLruBlockCache

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7038//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7038//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7038//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7038//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7038//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7038//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7038//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7038//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7038//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7038//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12601488/HBASE-9435.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 44 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.io.hfile.TestLruBlockCache Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7038//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7038//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7038//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7038//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7038//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7038//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7038//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7038//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7038//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7038//console This message is automatically generated.
          Hide
          stack added a comment -

          Skimmed. Looks good. Committed to 0.96 and trunk. Thanks Francis.

          Show
          stack added a comment - Skimmed. Looks good. Committed to 0.96 and trunk. Thanks Francis.
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in hbase-0.96 #11 (See https://builds.apache.org/job/hbase-0.96/11/)
          HBASE-9435 Fix jersey serialization/deserialization of json objects (stack: rev 1520178)

          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/CellModel.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/CellSetModel.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/ColumnSchemaModel.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/RowModel.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/StorageClusterVersionModel.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/TableSchemaModel.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/provider/JacksonProvider.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/TestSchemaResource.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/TestStatusResource.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestCellModel.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestCellSetModel.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestColumnSchemaModel.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestModelBase.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestRowModel.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestScannerModel.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestStorageClusterStatusModel.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestStorageClusterVersionModel.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableInfoModel.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableListModel.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableRegionModel.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableSchemaModel.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestVersionModel.java
          Show
          Hudson added a comment - SUCCESS: Integrated in hbase-0.96 #11 (See https://builds.apache.org/job/hbase-0.96/11/ ) HBASE-9435 Fix jersey serialization/deserialization of json objects (stack: rev 1520178) /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/CellModel.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/CellSetModel.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/ColumnSchemaModel.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/RowModel.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/StorageClusterVersionModel.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/TableSchemaModel.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/provider/JacksonProvider.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/TestSchemaResource.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/TestStatusResource.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestCellModel.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestCellSetModel.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestColumnSchemaModel.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestModelBase.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestRowModel.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestScannerModel.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestStorageClusterStatusModel.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestStorageClusterVersionModel.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableInfoModel.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableListModel.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableRegionModel.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableSchemaModel.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestVersionModel.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-TRUNK #4468 (See https://builds.apache.org/job/HBase-TRUNK/4468/)
          HBASE-9435 Fix jersey serialization/deserialization of json objects (stack: rev 1520179)

          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/CellModel.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/CellSetModel.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/ColumnSchemaModel.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/RowModel.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/StorageClusterVersionModel.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/TableSchemaModel.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/provider/JacksonProvider.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/TestSchemaResource.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/TestStatusResource.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestCellModel.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestCellSetModel.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestColumnSchemaModel.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestModelBase.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestRowModel.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestScannerModel.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestStorageClusterStatusModel.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestStorageClusterVersionModel.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableInfoModel.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableListModel.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableRegionModel.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableSchemaModel.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestVersionModel.java
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #4468 (See https://builds.apache.org/job/HBase-TRUNK/4468/ ) HBASE-9435 Fix jersey serialization/deserialization of json objects (stack: rev 1520179) /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/CellModel.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/CellSetModel.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/ColumnSchemaModel.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/RowModel.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/StorageClusterVersionModel.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/TableSchemaModel.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/provider/JacksonProvider.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/TestSchemaResource.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/TestStatusResource.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestCellModel.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestCellSetModel.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestColumnSchemaModel.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestModelBase.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestRowModel.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestScannerModel.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestStorageClusterStatusModel.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestStorageClusterVersionModel.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableInfoModel.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableListModel.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableRegionModel.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableSchemaModel.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestVersionModel.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in hbase-0.96-hadoop2 #6 (See https://builds.apache.org/job/hbase-0.96-hadoop2/6/)
          HBASE-9435 Fix jersey serialization/deserialization of json objects (stack: rev 1520178)

          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/CellModel.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/CellSetModel.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/ColumnSchemaModel.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/RowModel.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/StorageClusterVersionModel.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/TableSchemaModel.java
          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/provider/JacksonProvider.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/TestSchemaResource.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/TestStatusResource.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestCellModel.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestCellSetModel.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestColumnSchemaModel.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestModelBase.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestRowModel.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestScannerModel.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestStorageClusterStatusModel.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestStorageClusterVersionModel.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableInfoModel.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableListModel.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableRegionModel.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableSchemaModel.java
          • /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestVersionModel.java
          Show
          Hudson added a comment - SUCCESS: Integrated in hbase-0.96-hadoop2 #6 (See https://builds.apache.org/job/hbase-0.96-hadoop2/6/ ) HBASE-9435 Fix jersey serialization/deserialization of json objects (stack: rev 1520178) /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/CellModel.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/CellSetModel.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/ColumnSchemaModel.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/RowModel.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/StorageClusterVersionModel.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/TableSchemaModel.java /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/provider/JacksonProvider.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/TestSchemaResource.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/TestStatusResource.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestCellModel.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestCellSetModel.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestColumnSchemaModel.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestModelBase.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestRowModel.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestScannerModel.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestStorageClusterStatusModel.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestStorageClusterVersionModel.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableInfoModel.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableListModel.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableRegionModel.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableSchemaModel.java /hbase/branches/0.96/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestVersionModel.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #711 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/711/)
          HBASE-9435 Fix jersey serialization/deserialization of json objects (stack: rev 1520179)

          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/CellModel.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/CellSetModel.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/ColumnSchemaModel.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/RowModel.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/StorageClusterVersionModel.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/TableSchemaModel.java
          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/provider/JacksonProvider.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/TestSchemaResource.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/TestStatusResource.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestCellModel.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestCellSetModel.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestColumnSchemaModel.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestModelBase.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestRowModel.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestScannerModel.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestStorageClusterStatusModel.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestStorageClusterVersionModel.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableInfoModel.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableListModel.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableRegionModel.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableSchemaModel.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestVersionModel.java
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #711 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/711/ ) HBASE-9435 Fix jersey serialization/deserialization of json objects (stack: rev 1520179) /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/CellModel.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/CellSetModel.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/ColumnSchemaModel.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/RowModel.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/StorageClusterVersionModel.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/TableSchemaModel.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/provider/JacksonProvider.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/TestSchemaResource.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/TestStatusResource.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestCellModel.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestCellSetModel.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestColumnSchemaModel.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestModelBase.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestRowModel.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestScannerModel.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestStorageClusterStatusModel.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestStorageClusterVersionModel.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableInfoModel.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableListModel.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableRegionModel.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestTableSchemaModel.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/rest/model/TestVersionModel.java
          Hide
          Francis Liu added a comment -

          Thanks guys. Any chance we can backport this to 0.94 Lars Hofhansl?

          Show
          Francis Liu added a comment - Thanks guys. Any chance we can backport this to 0.94 Lars Hofhansl ?
          Hide
          Lars Hofhansl added a comment -

          I'm not very familiar with REST, does this introduce any backward compatibility issues?
          If not, I'd say we should backport. Patch looks reasonable to me.

          Any other opinions? stack, Andrew Purtell, Nick Dimiduk?
          Do you want to make a 0.94 patch Francis Liu?

          Show
          Lars Hofhansl added a comment - I'm not very familiar with REST, does this introduce any backward compatibility issues? If not, I'd say we should backport. Patch looks reasonable to me. Any other opinions? stack , Andrew Purtell , Nick Dimiduk ? Do you want to make a 0.94 patch Francis Liu ?
          Hide
          Nick Dimiduk added a comment -

          From the description:

          The patch is backward compatible except for StorageClusterStatusModel, which is broken anyway. It only shows one node in the liveNodes field.

          I think this is reasonable to backport to 0.94. The release notes on this ticket should be updated to indicate that in addition to the improvement, it also fixes the StorageClusterStatusModel issue.

          Show
          Nick Dimiduk added a comment - From the description: The patch is backward compatible except for StorageClusterStatusModel, which is broken anyway. It only shows one node in the liveNodes field. I think this is reasonable to backport to 0.94. The release notes on this ticket should be updated to indicate that in addition to the improvement, it also fixes the StorageClusterStatusModel issue.
          Hide
          Francis Liu added a comment -

          updated release notes. will make an 0.94 patch.

          Show
          Francis Liu added a comment - updated release notes. will make an 0.94 patch.
          Hide
          Devaraj Das added a comment -

          This broke one of our internal tests. The failing command:

           curl -H "Content-Type: application/json" --data '{"Row":{"@key":"cm93MQ==", "Cell":
          {"@column":"Y29sZmFtOmNvbA==", "$":"dmFsdWUx"}
          }}' http://localhost:17000/tcreatetbl/row1/colfam:col
          

          The exception thrown:

          <html>
          <head>
          <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1"/>
          <title>Error 500 Can not deserialize instance of java.util.List out of START_OBJECT token
           at [Source: org.mortbay.jetty.HttpParser$Input@6392f558; line: 1, column: 2] (through reference chain: org.apache.hadoop.hbase.rest.model.CellSetModel["Row"])</title>
          </head>
          <body><h2>HTTP ERROR 500</h2>
          <p>Problem accessing /tcreatetbl/row1/colfam:col. Reason:
          <pre>    Can not deserialize instance of java.util.List out of START_OBJECT token
           at [Source: org.mortbay.jetty.HttpParser$Input@6392f558; line: 1, column: 2] (through reference chain: org.apache.hadoop.hbase.rest.model.CellSetModel["Row"])</pre></p><h3>Caused by:</h3><pre>org.codehaus.jackson.map.JsonMappingException: Can not deserialize instance of java.util.List out of START_OBJECT token
           at [Source: org.mortbay.jetty.HttpParser$Input@6392f558; line: 1, column: 2] (through reference chain: org.apache.hadoop.hbase.rest.model.CellSetModel["Row"])
                  at org.codehaus.jackson.map.JsonMappingException.from(JsonMappingException.java:163)
                  at org.codehaus.jackson.map.deser.StdDeserializationContext.mappingException(StdDeserializationContext.java:198)
                  at org.codehaus.jackson.map.deser.CollectionDeserializer.handleNonArray(CollectionDeserializer.java:149)
                  at org.codehaus.jackson.map.deser.CollectionDeserializer.deserialize(CollectionDeserializer.java:107)
                  at org.codehaus.jackson.map.deser.CollectionDeserializer.deserialize(CollectionDeserializer.java:97)
          
          Show
          Devaraj Das added a comment - This broke one of our internal tests. The failing command: curl -H "Content-Type: application/json" --data '{"Row":{"@key":"cm93MQ==", "Cell": {"@column":"Y29sZmFtOmNvbA==", "$":"dmFsdWUx"} }}' http://localhost:17000/tcreatetbl/row1/colfam:col The exception thrown: <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1"/> <title>Error 500 Can not deserialize instance of java.util.List out of START_OBJECT token at [Source: org.mortbay.jetty.HttpParser$Input@6392f558; line: 1, column: 2] (through reference chain: org.apache.hadoop.hbase.rest.model.CellSetModel["Row"])</title> </head> <body><h2>HTTP ERROR 500</h2> <p>Problem accessing /tcreatetbl/row1/colfam:col. Reason: <pre> Can not deserialize instance of java.util.List out of START_OBJECT token at [Source: org.mortbay.jetty.HttpParser$Input@6392f558; line: 1, column: 2] (through reference chain: org.apache.hadoop.hbase.rest.model.CellSetModel["Row"])</pre></p><h3>Caused by:</h3><pre>org.codehaus.jackson.map.JsonMappingException: Can not deserialize instance of java.util.List out of START_OBJECT token at [Source: org.mortbay.jetty.HttpParser$Input@6392f558; line: 1, column: 2] (through reference chain: org.apache.hadoop.hbase.rest.model.CellSetModel["Row"]) at org.codehaus.jackson.map.JsonMappingException.from(JsonMappingException.java:163) at org.codehaus.jackson.map.deser.StdDeserializationContext.mappingException(StdDeserializationContext.java:198) at org.codehaus.jackson.map.deser.CollectionDeserializer.handleNonArray(CollectionDeserializer.java:149) at org.codehaus.jackson.map.deser.CollectionDeserializer.deserialize(CollectionDeserializer.java:107) at org.codehaus.jackson.map.deser.CollectionDeserializer.deserialize(CollectionDeserializer.java:97)
          Hide
          Devaraj Das added a comment -

          Francis Liu, mind taking a look? I am concerned that this breaks applications (at least we should understand what the problem is). Until then I am marking this as a blocker. (cc stack).

          Show
          Devaraj Das added a comment - Francis Liu , mind taking a look? I am concerned that this breaks applications (at least we should understand what the problem is). Until then I am marking this as a blocker. (cc stack ).
          Hide
          Devaraj Das added a comment - - edited

          This command works (changed some braces and removed '@'):

          curl -H "Content-Type: application/json" --data '{"Row":[{"key":"cm93MQ==", "Cell":
          [{"column":"Y29sZmFtOmNvbA==", "$":"dmFsdWUx"}]}]}' http://localhost:17000/tcreatetbl/row1/colfam:col
          
          Show
          Devaraj Das added a comment - - edited This command works (changed some braces and removed '@'): curl -H "Content-Type: application/json" --data '{"Row":[{"key":"cm93MQ==", "Cell": [{"column":"Y29sZmFtOmNvbA==", "$":"dmFsdWUx"}]}]}' http://localhost:17000/tcreatetbl/row1/colfam:col
          Hide
          Nick Dimiduk added a comment -

          Devaraj's test results indicate this is NOT a backwards compatible patch, to the extent described in the release note. Reopening so that it can be addressed.

          Show
          Nick Dimiduk added a comment - Devaraj's test results indicate this is NOT a backwards compatible patch, to the extent described in the release note. Reopening so that it can be addressed.
          Hide
          Francis Liu added a comment -

          I'll take look. Did these tests pass against a previous version of 0.96?

          Show
          Francis Liu added a comment - I'll take look. Did these tests pass against a previous version of 0.96?
          Hide
          Devaraj Das added a comment -

          If I revert this patch, yes, it works.

          Show
          Devaraj Das added a comment - If I revert this patch, yes, it works.
          Hide
          Francis Liu added a comment -

          Nick, Devaraj and I had a quick discussion over this. Here's the quick summary:

          Prior to this patch http requests using json representations with or without the '@' prefix were both valid. With this patch only no-'@'-prefix requests are valid.

          The '@' prefix style notation is known as MAPPED notation in jersey, tho we have been running with NATURAL notation (no '@' prefix) since the code was checked-in in 2009. Which seems to be a bug in jersey, which is no longer surfaced with this patch since we use jackson. Tho server responses are always represented using the NATURAL notation.

          This problem is further exacerbated by the fact that our stargate doc is inconsistent or wrong. Request examples use a mix of MAPPED or NATURAL notation. While some responses use the MAPPED notation.

          Given this situation we can either continue to support requests which use the MAPPED notation. Or we can deprecate support for that which seems cleaner and would cause less confusion IMHO. One concern here is the impact to users if we deprecate support? Thoughts?

          It's a given that we'll have to update the documentation. Nick has suggested we deprecate the wiki and link the book to the rest javadoc.

          Show
          Francis Liu added a comment - Nick, Devaraj and I had a quick discussion over this. Here's the quick summary: Prior to this patch http requests using json representations with or without the '@' prefix were both valid. With this patch only no-'@'-prefix requests are valid. The '@' prefix style notation is known as MAPPED notation in jersey, tho we have been running with NATURAL notation (no '@' prefix) since the code was checked-in in 2009. Which seems to be a bug in jersey, which is no longer surfaced with this patch since we use jackson. Tho server responses are always represented using the NATURAL notation. This problem is further exacerbated by the fact that our stargate doc is inconsistent or wrong. Request examples use a mix of MAPPED or NATURAL notation. While some responses use the MAPPED notation. Given this situation we can either continue to support requests which use the MAPPED notation. Or we can deprecate support for that which seems cleaner and would cause less confusion IMHO. One concern here is the impact to users if we deprecate support? Thoughts? It's a given that we'll have to update the documentation. Nick has suggested we deprecate the wiki and link the book to the rest javadoc.
          Hide
          Devaraj Das added a comment -

          +1 on the doc update (and no changes in the code)

          Show
          Devaraj Das added a comment - +1 on the doc update (and no changes in the code)
          Hide
          Francis Liu added a comment -

          ping Jimmy Xiang, in case he has some input.

          Show
          Francis Liu added a comment - ping Jimmy Xiang , in case he has some input.
          Hide
          Jimmy Xiang added a comment -

          For 0.96, I think it is fine. We should not backport it to 0.94 due to the compatibility issue. +1 to fix the doc.

          Show
          Jimmy Xiang added a comment - For 0.96, I think it is fine. We should not backport it to 0.94 due to the compatibility issue. +1 to fix the doc.
          Hide
          Francis Liu added a comment -

          +1 sounds good to me.

          Show
          Francis Liu added a comment - +1 sounds good to me.
          Hide
          Francis Liu added a comment -

          Not unless there's any objections. I'll start updating the doc and submit a patch in a few days.

          Show
          Francis Liu added a comment - Not unless there's any objections. I'll start updating the doc and submit a patch in a few days.
          Hide
          Nick Dimiduk added a comment -

          In that case, we can close this one out again. Can you update the release notes to document the additional incompatible API changes for our users? Thanks.

          Show
          Nick Dimiduk added a comment - In that case, we can close this one out again. Can you update the release notes to document the additional incompatible API changes for our users? Thanks.

            People

            • Assignee:
              Francis Liu
              Reporter:
              Francis Liu
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development