HBase
  1. HBase
  2. HBASE-9382

replicateWALEntry doesn't use the replication handlers

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.95.2
    • Fix Version/s: 0.98.0, 0.96.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Fix regression introduced by pb styling of method names. TODO: have client say priority of method and remove all this QosFunction reflection stuff; its brittle and messy.

      Description

      By default we assign 3 handlers for replication, but as far as I can tell the replication traffic uses the normal handlers in 0.96

      1. 9382.trunk.txt
        6 kB
        stack
      2. 9382.txt
        6 kB
        stack

        Activity

        Hide
        stack added a comment -

        Broken by:

        ------------------------------------------------------------------------
        r1501834 | stack | 2013-07-10 09:30:32 -0700 (Wed, 10 Jul 2013) | 1 line
        
        HBASE-8915 protobuf message style
        

        The priority checker thingy is brittle. It looks at name of incoming method to figure priority (we should do Elliott idea of having client just say what priority they want). The above change did this kinda thing:

          3 -  rpc replicateWALEntry(ReplicateWALEntryRequest)
          2 +  rpc ReplicateWALEntry(ReplicateWALEntryRequest)
          1      returns(ReplicateWALEntryResponse);
        

        When we ask the regionserver its method via reflection it returns the proper java method name 'replicationWALEntry' but incoming, pb has method name as 'ReplicationWALEntry'.

        Show
        stack added a comment - Broken by: ------------------------------------------------------------------------ r1501834 | stack | 2013-07-10 09:30:32 -0700 (Wed, 10 Jul 2013) | 1 line HBASE-8915 protobuf message style The priority checker thingy is brittle. It looks at name of incoming method to figure priority (we should do Elliott idea of having client just say what priority they want). The above change did this kinda thing: 3 - rpc replicateWALEntry(ReplicateWALEntryRequest) 2 + rpc ReplicateWALEntry(ReplicateWALEntryRequest) 1 returns(ReplicateWALEntryResponse); When we ask the regionserver its method via reflection it returns the proper java method name 'replicationWALEntry' but incoming, pb has method name as 'ReplicationWALEntry'.
        Hide
        stack added a comment -

        All priority was broke. Here is simple fix and test. This patch is for 0.95.

        Show
        stack added a comment - All priority was broke. Here is simple fix and test. This patch is for 0.95.
        Hide
        stack added a comment -

        Trunk version.

        Show
        stack added a comment - Trunk version.
        Hide
        Jean-Daniel Cryans added a comment -

        I'll test this one out this morning.

        Show
        Jean-Daniel Cryans added a comment - I'll test this one out this morning.
        Hide
        Jean-Daniel Cryans added a comment -

        It all checks out, +1

        Show
        Jean-Daniel Cryans added a comment - It all checks out, +1
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12600741/9382.trunk.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified tests.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6988//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6988//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6988//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6988//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6988//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6988//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6988//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6988//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6988//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6988//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12600741/9382.trunk.txt against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6988//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6988//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6988//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6988//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6988//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6988//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6988//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6988//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6988//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6988//console This message is automatically generated.
        Hide
        stack added a comment -

        Committed to 0.95 and trunk. Thanks for review and trying it Jean-Daniel Cryans

        Show
        stack added a comment - Committed to 0.95 and trunk. Thanks for review and trying it Jean-Daniel Cryans
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in hbase-0.95 #509 (See https://builds.apache.org/job/hbase-0.95/509/)
        HBASE-9382 replicateWALEntry doesn't use the replication handlers (stack: rev 1519018)

        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/QosFunction.java
        • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestQosFunction.java
        Show
        Hudson added a comment - SUCCESS: Integrated in hbase-0.95 #509 (See https://builds.apache.org/job/hbase-0.95/509/ ) HBASE-9382 replicateWALEntry doesn't use the replication handlers (stack: rev 1519018) /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/QosFunction.java /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestQosFunction.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK #4450 (See https://builds.apache.org/job/HBase-TRUNK/4450/)
        HBASE-9382 replicateWALEntry doesn't use the replication handlers (stack: rev 1519017)

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/QosFunction.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestQosFunction.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #4450 (See https://builds.apache.org/job/HBase-TRUNK/4450/ ) HBASE-9382 replicateWALEntry doesn't use the replication handlers (stack: rev 1519017) /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/QosFunction.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestQosFunction.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in hbase-0.95-on-hadoop2 #282 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/282/)
        HBASE-9382 replicateWALEntry doesn't use the replication handlers (stack: rev 1519018)

        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/QosFunction.java
        • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestQosFunction.java
        Show
        Hudson added a comment - FAILURE: Integrated in hbase-0.95-on-hadoop2 #282 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/282/ ) HBASE-9382 replicateWALEntry doesn't use the replication handlers (stack: rev 1519018) /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/QosFunction.java /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestQosFunction.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #705 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/705/)
        HBASE-9382 replicateWALEntry doesn't use the replication handlers (stack: rev 1519017)

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/QosFunction.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestQosFunction.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #705 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/705/ ) HBASE-9382 replicateWALEntry doesn't use the replication handlers (stack: rev 1519017) /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleRpcScheduler.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/QosFunction.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestQosFunction.java

          People

          • Assignee:
            stack
            Reporter:
            Jean-Daniel Cryans
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development