HBase
  1. HBase
  2. HBASE-9267

StochasticLoadBalancer goes over its processing time limit

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.95.2
    • Fix Version/s: 0.98.0, 0.96.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      I trying out 0.95.2, I left it running over the weekend (8 RS, average load between 12 and 3 regions) and right now the balancer runs for 12 mins:

      2013-08-19 21:54:45,534 DEBUG [jdec2hbase0403-1.vpc.cloudera.com,60000,1376689696384-BalancerChore] org.apache.hadoop.hbase.master.balancer.StochasticLoadBalancer: Could not find a better load balance plan. Tried 0 different configurations in 777309ms, and did not find anything with a computed cost less than 36.32576937689094

      It seems it slowly crept up there, yesterday it was doing:

      2013-08-18 20:53:17,232 DEBUG [jdec2hbase0403-1.vpc.cloudera.com,60000,1376689696384-BalancerChore] org.apache.hadoop.hbase.master.balancer.StochasticLoadBalancer: Could not find a better load balance plan. Tried 0 different configurations in 257374ms, and did not find anything with a computed cost less than 36.3251082542424

      And originally it was doing 1 minute.

      In the jstack I see a 1000 of these and jstack doesn't want to show me the whole thing:

      at java.util.SubList$1.nextIndex(AbstractList.java:713)

      1. HBASE-9267-0.patch
        11 kB
        Elliott Clark
      2. HBASE-9267-1.patch
        11 kB
        Elliott Clark
      3. HBASE-9267-2.patch
        11 kB
        Elliott Clark
      4. HBASE-9267-3.patch
        11 kB
        Elliott Clark
      5. HBASE-9267-4.patch
        11 kB
        Elliott Clark

        Activity

        Hide
        Jean-Daniel Cryans added a comment -

        Basically if I do this in the shell on a freshly started master:

        (0..100).each do balancer end

        The time it takes to balance goes higher most of the time:

        hbase(main):002:0> (0..100).each do balancer end
        true
        0 row(s) in 9.0110 seconds
        true
        0 row(s) in 10.1910 seconds
        true
        0 row(s) in 11.2180 seconds
        true
        0 row(s) in 12.5670 seconds
        true
        0 row(s) in 13.8070 seconds
        true
        0 row(s) in 17.5170 seconds
        true
        0 row(s) in 18.8010 seconds
        true
        0 row(s) in 20.2750 seconds
        true
        0 row(s) in 22.9260 seconds
        true
        0 row(s) in 18.4760 seconds
        true
        0 row(s) in 32.1890 seconds
        ERROR: com.google.protobuf.ServiceException: java.net.SocketTimeoutException: Call to jdec2hbase0403-1.vpc.cloudera.com/172.25.3.222:60000 failed because java.net.SocketTimeoutException: 60000 millis timeout while waiting for channel to be ready for read. ch : java.nio.channels.SocketChannel[connected local=/172.25.3.222:42034 remote=jdec2hbase0403-1.vpc.cloudera.com/172.25.3.222:60000]

        The last one took 59 seconds according to the master log.

        Show
        Jean-Daniel Cryans added a comment - Basically if I do this in the shell on a freshly started master: (0..100).each do balancer end The time it takes to balance goes higher most of the time: hbase(main):002:0> (0..100).each do balancer end true 0 row(s) in 9.0110 seconds true 0 row(s) in 10.1910 seconds true 0 row(s) in 11.2180 seconds true 0 row(s) in 12.5670 seconds true 0 row(s) in 13.8070 seconds true 0 row(s) in 17.5170 seconds true 0 row(s) in 18.8010 seconds true 0 row(s) in 20.2750 seconds true 0 row(s) in 22.9260 seconds true 0 row(s) in 18.4760 seconds true 0 row(s) in 32.1890 seconds ERROR: com.google.protobuf.ServiceException: java.net.SocketTimeoutException: Call to jdec2hbase0403-1.vpc.cloudera.com/172.25.3.222:60000 failed because java.net.SocketTimeoutException: 60000 millis timeout while waiting for channel to be ready for read. ch : java.nio.channels.SocketChannel [connected local=/172.25.3.222:42034 remote=jdec2hbase0403-1.vpc.cloudera.com/172.25.3.222:60000] The last one took 59 seconds according to the master log.
        Hide
        Elliott Clark added a comment -

        Pretty sure that I have the solution for this.

        Show
        Elliott Clark added a comment - Pretty sure that I have the solution for this.
        Hide
        Elliott Clark added a comment -

        here's a patch that remove the use of subList for region load.

        Show
        Elliott Clark added a comment - here's a patch that remove the use of subList for region load.
        Hide
        Elliott Clark added a comment -

        Some formatting.

        Show
        Elliott Clark added a comment - Some formatting.
        Hide
        Elliott Clark added a comment -

        Patch to protect against nulls.

        Show
        Elliott Clark added a comment - Patch to protect against nulls.
        Hide
        Ted Yu added a comment -

        Patch that treats List<RegionLoad> as circular buffer.
        There is no array copying involved.

        For reference only.

        Show
        Ted Yu added a comment - Patch that treats List<RegionLoad> as circular buffer. There is no array copying involved. For reference only.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12598865/HBASE-9267-0.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 4 new or modified tests.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.coprocessor.TestMasterObserver
        org.apache.hadoop.hbase.client.TestMultiParallel
        org.apache.hadoop.hbase.TestRegionRebalancing

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6817//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6817//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6817//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6817//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6817//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6817//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6817//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6817//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6817//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6817//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12598865/HBASE-9267-0.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.coprocessor.TestMasterObserver org.apache.hadoop.hbase.client.TestMultiParallel org.apache.hadoop.hbase.TestRegionRebalancing Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6817//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6817//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6817//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6817//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6817//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6817//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6817//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6817//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6817//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6817//console This message is automatically generated.
        Hide
        Elliott Clark added a comment -

        Ted the ordering of the region loads is important. so unless you change all places that iterate over it then it's not really going to work.

        Show
        Elliott Clark added a comment - Ted the ordering of the region loads is important. so unless you change all places that iterate over it then it's not really going to work.
        Hide
        Jean-Daniel Cryans added a comment -

        I'm +1 on Elliott's third patch (haven't tried Ted's), although I would like to see a Hadoop QA run on it.

        Now it only takes 1.5 seconds to see there's nothing to balance, and it's constant (woohoo).

        Show
        Jean-Daniel Cryans added a comment - I'm +1 on Elliott's third patch (haven't tried Ted's), although I would like to see a Hadoop QA run on it. Now it only takes 1.5 seconds to see there's nothing to balance, and it's constant (woohoo).
        Hide
        Ted Yu added a comment -

        the ordering of the region loads is important

        Understood.

        This involves passing startingPosInLoads to Cluster constructor and establishing indices corresponding to regionLoads.

        Show
        Ted Yu added a comment - the ordering of the region loads is important Understood. This involves passing startingPosInLoads to Cluster constructor and establishing indices corresponding to regionLoads.
        Hide
        Elliott Clark added a comment -

        Ted Yu That's not what your code does.

        You're only overwriting in a circle. The iterators will still start at index 0.

        max size of 3
        Add:
        A
        B
        C

        results in:
        [ A B C]

        now add D

        results in:

        [ D B C]

        Any iterations over the list will now be

        D -> B -> C

        C should be the second seen. Instead it's the third.

        On top of that because of all the hash lookups (3 vs 1) and the boxing and un-boxing (2 v 0) your solution is going to run about the same amount of time.

        Show
        Elliott Clark added a comment - Ted Yu That's not what your code does. You're only overwriting in a circle. The iterators will still start at index 0. max size of 3 Add: A B C results in: [ A B C] now add D results in: [ D B C] Any iterations over the list will now be D -> B -> C C should be the second seen. Instead it's the third. On top of that because of all the hash lookups (3 vs 1) and the boxing and un-boxing (2 v 0) your solution is going to run about the same amount of time.
        Hide
        Elliott Clark added a comment -

        If you want a circular ring buffer CircularFifoBuffer is the correct answer.

        Show
        Elliott Clark added a comment - If you want a circular ring buffer CircularFifoBuffer is the correct answer.
        Hide
        Ted Yu added a comment -

        The patch I attached was not complete.

        all the hash lookups (3 vs 1)

        The additional index can be bundled with List<RegionLoad> in the loads map.

        Thanks for looking at my patch.

        Show
        Ted Yu added a comment - The patch I attached was not complete. all the hash lookups (3 vs 1) The additional index can be bundled with List<RegionLoad> in the loads map. Thanks for looking at my patch.
        Hide
        Ted Yu added a comment -

        CircularFifoBuffer is the correct answer.

        Good one.

        Show
        Ted Yu added a comment - CircularFifoBuffer is the correct answer. Good one.
        Hide
        Ted Yu added a comment -

        Revised patch uses CircularFifoBuffer.

        The following tests passed:
        TestBaseLoadBalancer,TestStochasticLoadBalancer,TestMasterFailoverBalancerPersistence

        Show
        Ted Yu added a comment - Revised patch uses CircularFifoBuffer. The following tests passed: TestBaseLoadBalancer,TestStochasticLoadBalancer,TestMasterFailoverBalancerPersistence
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12598879/9267-suggest.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6819//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6819//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6819//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6819//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6819//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6819//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6819//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6819//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6819//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6819//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12598879/9267-suggest.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6819//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6819//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6819//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6819//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6819//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6819//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6819//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6819//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6819//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6819//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12598888/9267-suggest-2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6821//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6821//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6821//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6821//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6821//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6821//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6821//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6821//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6821//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6821//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12598888/9267-suggest-2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6821//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6821//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6821//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6821//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6821//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6821//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6821//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6821//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6821//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6821//console This message is automatically generated.
        Hide
        stack added a comment -

        What is going on here? I thought this was Elliott's issue? Is it being hijacked?

        Show
        stack added a comment - What is going on here? I thought this was Elliott's issue? Is it being hijacked?
        Hide
        stack added a comment -

        Ted Yu Can you take your pollution elsewhere, to another issue? I can only imagine you are pissing off the lads that are trying to fix this issue here what w/ your interjection of unfinished amendments that have to be explained back to you by the original patches' author.

        Show
        stack added a comment - Ted Yu Can you take your pollution elsewhere, to another issue? I can only imagine you are pissing off the lads that are trying to fix this issue here what w/ your interjection of unfinished amendments that have to be explained back to you by the original patches' author.
        Hide
        Ted Yu added a comment -

        I have removed my attachments.

        Elliott's solution is fine.

        I will pay attention in the future.

        Show
        Ted Yu added a comment - I have removed my attachments. Elliott's solution is fine. I will pay attention in the future.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12598878/HBASE-9267-2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 4 new or modified tests.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6825//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6825//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6825//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6825//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6825//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6825//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6825//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6825//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6825//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6825//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12598878/HBASE-9267-2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6825//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6825//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6825//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6825//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6825//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6825//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6825//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6825//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6825//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6825//console This message is automatically generated.
        Hide
        Elliott Clark added a comment -

        Here's a patch that does circular buffers with the correct ordering on iteration.

        Show
        Elliott Clark added a comment - Here's a patch that does circular buffers with the correct ordering on iteration.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12599028/HBASE-9267-3.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 4 new or modified tests.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        -1 core tests. The patch failed these unit tests:
        org.apache.hadoop.hbase.coprocessor.TestMasterObserver
        org.apache.hadoop.hbase.thrift.TestThriftServer
        org.apache.hadoop.hbase.client.TestMultiParallel
        org.apache.hadoop.hbase.TestRegionRebalancing

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6830//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6830//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6830//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6830//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6830//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6830//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6830//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6830//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6830//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6830//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12599028/HBASE-9267-3.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.coprocessor.TestMasterObserver org.apache.hadoop.hbase.thrift.TestThriftServer org.apache.hadoop.hbase.client.TestMultiParallel org.apache.hadoop.hbase.TestRegionRebalancing Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6830//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6830//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6830//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6830//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6830//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6830//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6830//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6830//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6830//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6830//console This message is automatically generated.
        Hide
        Elliott Clark added a comment -

        Blah java's type system.

        Show
        Elliott Clark added a comment - Blah java's type system.
        Hide
        stack added a comment -

        Patch looks reasonable to me (skimmed). Does it work? If so +1.

        Show
        stack added a comment - Patch looks reasonable to me (skimmed). Does it work? If so +1.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12599069/HBASE-9267-4.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 4 new or modified tests.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 site. The patch appears to cause mvn site goal to fail.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6832//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6832//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12599069/HBASE-9267-4.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6832//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6832//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6832//console This message is automatically generated.
        Hide
        Jean-Daniel Cryans added a comment -

        Yesterday I was playing more with v2 and v3 and although I don't see the sublist issue anymore, the time it takes to balance always goes up until it reaches 60 seconds. The more I think about it the less I like it... there's no way to kill the balancer while it's running (AFAIK) and it blocks a couple of other things like HBCK. We could discuss this on dev@ or another jira though.

        So I'm still +1 on the patch.

        Show
        Jean-Daniel Cryans added a comment - Yesterday I was playing more with v2 and v3 and although I don't see the sublist issue anymore, the time it takes to balance always goes up until it reaches 60 seconds. The more I think about it the less I like it... there's no way to kill the balancer while it's running (AFAIK) and it blocks a couple of other things like HBCK. We could discuss this on dev@ or another jira though. So I'm still +1 on the patch.
        Hide
        Elliott Clark added a comment -

        v3 didn't really work at al because java's dumb. I'm not seeing what you're seeing at all.

        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0010 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0010 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0010 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0010 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0010 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0010 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0010 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0030 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0010 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0010 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0010 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0010 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0010 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0010 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0010 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0010 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0010 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0010 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0010 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0390 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0030 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0010 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0010 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0010 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0010 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0010 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0010 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0010 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0390 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0030 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0010 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
        true                                                                                                                                                                                                      
        0 row(s) in 0.0020 seconds
        
         => 0..100 
        1.9.3-p429 :011 > 
        
        Show
        Elliott Clark added a comment - v3 didn't really work at al because java's dumb. I'm not seeing what you're seeing at all. true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0010 seconds true 0 row(s) in 0.0010 seconds true 0 row(s) in 0.0010 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0010 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0010 seconds true 0 row(s) in 0.0010 seconds true 0 row(s) in 0.0010 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0030 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0010 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0010 seconds true 0 row(s) in 0.0010 seconds true 0 row(s) in 0.0010 seconds true 0 row(s) in 0.0010 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0010 seconds true 0 row(s) in 0.0010 seconds true 0 row(s) in 0.0010 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0010 seconds true 0 row(s) in 0.0010 seconds true 0 row(s) in 0.0010 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0390 seconds true 0 row(s) in 0.0030 seconds true 0 row(s) in 0.0010 seconds true 0 row(s) in 0.0010 seconds true 0 row(s) in 0.0010 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0010 seconds true 0 row(s) in 0.0010 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0010 seconds true 0 row(s) in 0.0010 seconds true 0 row(s) in 0.0390 seconds true 0 row(s) in 0.0030 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0010 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds true 0 row(s) in 0.0020 seconds => 0..100 1.9.3-p429 :011 >
        Hide
        Jean-Daniel Cryans added a comment -

        Oh you're right, I deployed v3 and got that but then I saw another issue somewhere else and my ADHD kicked in so I chased that one instead. What I described was v2. Do you think v4 would be any different? My jstacking was showing that the time is just spent computing costs.

        Show
        Jean-Daniel Cryans added a comment - Oh you're right, I deployed v3 and got that but then I saw another issue somewhere else and my ADHD kicked in so I chased that one instead. What I described was v2. Do you think v4 would be any different? My jstacking was showing that the time is just spent computing costs.
        Hide
        Elliott Clark added a comment -

        Committed. I'll look at the cost functions taking too long in another issue if it can be reproduced.

        Show
        Elliott Clark added a comment - Committed. I'll look at the cost functions taking too long in another issue if it can be reproduced.
        Hide
        Hudson added a comment -

        FAILURE: Integrated in hbase-0.95-on-hadoop2 #262 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/262/)
        HBASE-9267 Change region load in load balancer to use circular array. (eclark: rev 1516334)

        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
        • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java
        Show
        Hudson added a comment - FAILURE: Integrated in hbase-0.95-on-hadoop2 #262 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/262/ ) HBASE-9267 Change region load in load balancer to use circular array. (eclark: rev 1516334) /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #691 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/691/)
        HBASE-9267 Change region load in load balancer to use circular array. (eclark: rev 1516335)

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #691 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/691/ ) HBASE-9267 Change region load in load balancer to use circular array. (eclark: rev 1516335) /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #4422 (See https://builds.apache.org/job/HBase-TRUNK/4422/)
        HBASE-9267 Change region load in load balancer to use circular array. (eclark: rev 1516335)

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java
        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #4422 (See https://builds.apache.org/job/HBase-TRUNK/4422/ ) HBASE-9267 Change region load in load balancer to use circular array. (eclark: rev 1516335) /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in hbase-0.95 #483 (See https://builds.apache.org/job/hbase-0.95/483/)
        HBASE-9267 Change region load in load balancer to use circular array. (eclark: rev 1516334)

        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java
        • /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
        • /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java
        Show
        Hudson added a comment - SUCCESS: Integrated in hbase-0.95 #483 (See https://builds.apache.org/job/hbase-0.95/483/ ) HBASE-9267 Change region load in load balancer to use circular array. (eclark: rev 1516334) /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java

          People

          • Assignee:
            Elliott Clark
            Reporter:
            Jean-Daniel Cryans
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development