Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-9236

region_mover#getTable() should use TableName.toString() instead of Bytes.toString()

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.98.0, 0.96.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      region_mover#getTable() has the following code:

        key = Bytes.toString(name)
      

      where name is TableName. However there is no Bytes.toString(TableName) defined.
      TableName.toString() should be used instead.

        Activity

        Hide
        yuzhihong@gmail.com Ted Yu added a comment -

        Francis Liu:
        Mind taking a look at the patch ?

        Show
        yuzhihong@gmail.com Ted Yu added a comment - Francis Liu : Mind taking a look at the patch ?
        Hide
        toffer Francis Liu added a comment -

        +1 (non-binding)
        toString() or getNameAsString() should work.

        Show
        toffer Francis Liu added a comment - +1 (non-binding) toString() or getNameAsString() should work.
        Hide
        yuzhihong@gmail.com Ted Yu added a comment -

        Yeah, the two methods return the same field.

        Show
        yuzhihong@gmail.com Ted Yu added a comment - Yeah, the two methods return the same field.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12598315/9236-v1.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        +1 site. The mvn site goal succeeds with this patch.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6771//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6771//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6771//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6771//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6771//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6771//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6771//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6771//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6771//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6771//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12598315/9236-v1.txt against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/6771//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6771//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6771//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6771//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6771//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6771//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6771//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6771//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/6771//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/6771//console This message is automatically generated.
        Hide
        yuzhihong@gmail.com Ted Yu added a comment -

        Integrated to 0.95 and trunk.

        Thanks for the review, Francis.

        Show
        yuzhihong@gmail.com Ted Yu added a comment - Integrated to 0.95 and trunk. Thanks for the review, Francis.
        Hide
        jmspaggi Jean-Marc Spaggiari added a comment -

        So that should also fix HBASE-8803, right?

        Show
        jmspaggi Jean-Marc Spaggiari added a comment - So that should also fix HBASE-8803 , right?
        Hide
        jmspaggi Jean-Marc Spaggiari added a comment -

        BTW, why are we not doing this directly into HBASE-8803? It's kind of duplicate, no?

        Show
        jmspaggi Jean-Marc Spaggiari added a comment - BTW, why are we not doing this directly into HBASE-8803 ? It's kind of duplicate, no?
        Hide
        yuzhihong@gmail.com Ted Yu added a comment -

        Just saw that.

        should also fix HBASE-8803

        I think so.

        Show
        yuzhihong@gmail.com Ted Yu added a comment - Just saw that. should also fix HBASE-8803 I think so.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in hbase-0.95-on-hadoop2 #246 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/246/)
        HBASE-9236 region_mover#getTable() should use TableName.toString() instead of Bytes.toString() (tedyu: rev 1514553)

        • /hbase/branches/0.95/bin/region_mover.rb
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in hbase-0.95-on-hadoop2 #246 (See https://builds.apache.org/job/hbase-0.95-on-hadoop2/246/ ) HBASE-9236 region_mover#getTable() should use TableName.toString() instead of Bytes.toString() (tedyu: rev 1514553) /hbase/branches/0.95/bin/region_mover.rb
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #4400 (See https://builds.apache.org/job/HBase-TRUNK/4400/)
        HBASE-9236 region_mover#getTable() should use TableName.toString() instead of Bytes.toString() (tedyu: rev 1514552)

        • /hbase/trunk/bin/region_mover.rb
        Show
        hudson Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #4400 (See https://builds.apache.org/job/HBase-TRUNK/4400/ ) HBASE-9236 region_mover#getTable() should use TableName.toString() instead of Bytes.toString() (tedyu: rev 1514552) /hbase/trunk/bin/region_mover.rb
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in hbase-0.95 #457 (See https://builds.apache.org/job/hbase-0.95/457/)
        HBASE-9236 region_mover#getTable() should use TableName.toString() instead of Bytes.toString() (tedyu: rev 1514553)

        • /hbase/branches/0.95/bin/region_mover.rb
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in hbase-0.95 #457 (See https://builds.apache.org/job/hbase-0.95/457/ ) HBASE-9236 region_mover#getTable() should use TableName.toString() instead of Bytes.toString() (tedyu: rev 1514553) /hbase/branches/0.95/bin/region_mover.rb
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #680 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/680/)
        HBASE-9236 region_mover#getTable() should use TableName.toString() instead of Bytes.toString() (tedyu: rev 1514552)

        • /hbase/trunk/bin/region_mover.rb
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #680 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/680/ ) HBASE-9236 region_mover#getTable() should use TableName.toString() instead of Bytes.toString() (tedyu: rev 1514552) /hbase/trunk/bin/region_mover.rb
        Hide
        lars_francke Lars Francke added a comment -

        This issue was closed as part of a bulk closing operation on 2015-11-20. All issues that have been resolved and where all fixVersions have been released have been closed (following discussions on the mailing list).

        Show
        lars_francke Lars Francke added a comment - This issue was closed as part of a bulk closing operation on 2015-11-20. All issues that have been resolved and where all fixVersions have been released have been closed (following discussions on the mailing list).

          People

          • Assignee:
            yuzhihong@gmail.com Ted Yu
            Reporter:
            yuzhihong@gmail.com Ted Yu
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development